Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove w3c check HttpClient #3235

Conversation

vishweshbankwar
Copy link
Member

@vishweshbankwar vishweshbankwar commented Apr 27, 2022

The check is no longer needed as we have stopped supporting 2.x versions.
Fixes #.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@vishweshbankwar vishweshbankwar changed the title Remove w3c check Remove w3c check HttpClient Apr 27, 2022
@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #3235 (ee35de9) into main (1bdb512) will increase coverage by 0.25%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3235      +/-   ##
==========================================
+ Coverage   85.30%   85.56%   +0.25%     
==========================================
  Files         261      261              
  Lines        9392     9385       -7     
==========================================
+ Hits         8012     8030      +18     
+ Misses       1380     1355      -25     
Impacted Files Coverage Δ
...tp/Implementation/HttpHandlerDiagnosticListener.cs 69.31% <100.00%> (-2.27%) ⬇️
...heus/Implementation/PrometheusCollectionManager.cs 82.27% <0.00%> (+2.53%) ⬆️
...metryProtocol/Implementation/ActivityExtensions.cs 91.44% <0.00%> (+2.70%) ⬆️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 82.35% <0.00%> (+5.88%) ⬆️
...xporter.OpenTelemetryProtocol/OtlpTraceExporter.cs 77.27% <0.00%> (+40.90%) ⬆️
...entation/ExportClient/OtlpGrpcTraceExportClient.cs 78.57% <0.00%> (+42.85%) ⬆️

@vishweshbankwar vishweshbankwar marked this pull request as ready for review April 27, 2022 22:54
@vishweshbankwar vishweshbankwar requested a review from a team April 27, 2022 22:54
@cijothomas cijothomas merged commit 0741a9d into open-telemetry:main Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants