Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zipkin Exporter fixes #2935

Merged
merged 2 commits into from
Feb 23, 2022

Conversation

cijothomas
Copy link
Member

@cijothomas cijothomas commented Feb 23, 2022

Part of #2872

Changes

Zipkin Exporter modified to not throw in Export method
Jaeger Exporter modified to use SuppressInstrumentationScope to prevents its internal operations from being instrumented. (More relevant since http support added, but even without it, this is following the Exporter recommendations from https://github.com/open-telemetry/opentelemetry-dotnet/tree/main/docs/trace/extending-the-sdk#exporter)

@cijothomas cijothomas requested a review from a team February 23, 2022 20:12
@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #2935 (f4af392) into main (72ade32) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2935   +/-   ##
=======================================
  Coverage   83.86%   83.86%           
=======================================
  Files         254      254           
  Lines        8941     8941           
=======================================
  Hits         7498     7498           
  Misses       1443     1443           
Impacted Files Coverage Δ
...rc/OpenTelemetry.Exporter.Zipkin/ZipkinExporter.cs 88.42% <100.00%> (ø)
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 96.87% <0.00%> (-0.79%) ⬇️
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs 72.22% <0.00%> (+0.92%) ⬆️

@cijothomas cijothomas changed the title Zipkin and Jaeger Exporter fixes Zipkin Exporter fixes Feb 23, 2022
@cijothomas cijothomas merged commit 68bca53 into open-telemetry:main Feb 23, 2022
@cijothomas cijothomas deleted the cijothomas/exporterfixes branch February 23, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants