Zipkin Exporter fixes (#2935)

open-telemetry · Feb 23, 2022 · 68bca53 · 68bca53
1 parent 72ade32
commit 68bca53
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/src/OpenTelemetry.Exporter.Zipkin/CHANGELOG.md b/src/OpenTelemetry.Exporter.Zipkin/CHANGELOG.md
@@ -2,6 +2,9 @@
 
 ## Unreleased
 
+* Modified Export method to catch all exceptions.
+  ([#2935](https://github.com/open-telemetry/opentelemetry-dotnet/pull/2935))
+
 ## 1.2.0-rc2
 
 Released 2022-Feb-02

diff --git a/src/OpenTelemetry.Exporter.Zipkin/ZipkinExporter.cs b/src/OpenTelemetry.Exporter.Zipkin/ZipkinExporter.cs
@@ -60,16 +60,16 @@ public ZipkinExporter(ZipkinExporterOptions options, HttpClient client = null)
         /// <inheritdoc/>
         public override ExportResult Export(in Batch<Activity> batch)
         {
-            if (this.LocalEndpoint == null)
-            {
-                this.SetLocalEndpointFromResource(this.ParentProvider.GetResource());
-            }
-
             // Prevent Zipkin's HTTP operations from being instrumented.
             using var scope = SuppressInstrumentationScope.Begin();
 
             try
             {
+                if (this.LocalEndpoint == null)
+                {
+                    this.SetLocalEndpointFromResource(this.ParentProvider.GetResource());
+                }
+
                 var requestUri = this.options.Endpoint;
 
                 using var request = new HttpRequestMessage(HttpMethod.Post, requestUri)