Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConsoleExporter to print Activity(Span) Links #2849

Merged
merged 2 commits into from
Feb 2, 2022
Merged

ConsoleExporter to print Activity(Span) Links #2849

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f25291
ConsoleExporter to print Activity(Span) Links
cijothomas Feb 2, 2022
46c6350
incorrect changelog
cijothomas Feb 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/OpenTelemetry.Exporter.Console/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ Released 2021-Nov-29
the `ConsoleMetricExporter` to export either manually or periodically.
([#2648](https://github.com/open-telemetry/opentelemetry-dotnet/pull/2648))

* ActivityExporter exports Activity Links.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: ConsoleActivityExporter

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* ActivityExporter exports Activity Links.
* Added `Activity.Links` support to `ConsoleActivityExporter`.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is supposed to be under "Unreleased" section?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reopen.


## 1.2.0-beta2

Released 2021-Nov-19
Expand Down
9 changes: 9 additions & 0 deletions src/OpenTelemetry.Exporter.Console/ConsoleActivityExporter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,15 @@ public override ExportResult Export(in Batch<Activity> batch)
}
}

if (activity.Links.Any())
{
this.WriteLine("Activity.Links:");
foreach (var activityLink in activity.Links)
{
this.WriteLine($" {activityLink.Context.TraceId} {activityLink.Context.SpanId}");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not want to print the Tags for the activity link?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coming in future PRs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far I haven't seen any semantic convention using Links much... The 1st one I am seeing is https://github.com/open-telemetry/opentelemetry-specification/pull/2078/files It doesn't yet use tags.

}
}

var resource = this.ParentProvider.GetResource();
if (resource != Resource.Empty)
{
Expand Down