ConsoleExporter to print Activity(Span) Links #2849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utpilla
reviewed
Feb 2, 2022
| @@ -12,6 +12,8 @@ Released 2021-Nov-29 | |||
| the `ConsoleMetricExporter` to export either manually or periodically. | |||
| ([#2648](https://github.com/open-telemetry/opentelemetry-dotnet/pull/2648)) | |||
|
|
|||
| * ActivityExporter exports Activity Links. | |||
There was a problem hiding this comment.
nit: ConsoleActivityExporter
There was a problem hiding this comment.
Suggested change
| * ActivityExporter exports Activity Links. | |
| * Added `Activity.Links` support to `ConsoleActivityExporter`. |
There was a problem hiding this comment.
This is supposed to be under "Unreleased" section?
utpilla
approved these changes
Feb 2, 2022
utpilla
reviewed
Feb 2, 2022
| this.WriteLine("Activity.Links:"); | ||
| foreach (var activityLink in activity.Links) | ||
| { | ||
| this.WriteLine($" {activityLink.Context.TraceId} {activityLink.Context.SpanId}"); |
There was a problem hiding this comment.
Do we not want to print the Tags for the activity link?
There was a problem hiding this comment.
So far I haven't seen any semantic convention using Links much... The 1st one I am seeing is https://github.com/open-telemetry/opentelemetry-specification/pull/2078/files It doesn't yet use tags.
Codecov Report
@@ Coverage Diff @@
## main #2849 +/- ##
=======================================
Coverage 83.76% 83.76%
=======================================
Files 250 250
Lines 8882 8882
=======================================
Hits 7440 7440
Misses 1442 1442 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #.
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes