Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Baggage Header name to baggage #2003

Merged

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Apr 20, 2021

Fixes #1967

Changes

  • Renamed BaggageHeader name to baggage (lowercase). BaggagePropagator.Extract and BaggagePropagator.Inject will now look for and add baggage to the carrier respectively
  • Updated HttpInstrumentationTests to look for baggage in Headers instead of Baggage. Although these look ups are case insensitive, I updated them to be consistent with the BaggageHeader Name.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes

@utpilla utpilla requested a review from a team April 20, 2021 23:25
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the CHANGELOG.md is updated.

@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #2003 (a39ba97) into main (f3912e5) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2003      +/-   ##
==========================================
+ Coverage   83.87%   83.91%   +0.03%     
==========================================
  Files         192      192              
  Lines        6184     6184              
==========================================
+ Hits         5187     5189       +2     
+ Misses        997      995       -2     
Impacted Files Coverage Δ
...metry.Api/Context/Propagation/BaggagePropagator.cs 83.92% <ø> (ø)
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 96.58% <0.00%> (+0.85%) ⬆️
...ZPages/Implementation/ZPagesExporterEventSource.cs 62.50% <0.00%> (+6.25%) ⬆️

@cijothomas cijothomas merged commit eb42939 into open-telemetry:main Apr 20, 2021
@utpilla utpilla deleted the utpilla/Rename-BaggageHeaderName branch June 3, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Baggage header should be lowercase
3 participants