Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baggage header should be lowercase #1967

Closed
Rast1234 opened this issue Apr 8, 2021 · 3 comments · Fixed by #2003
Closed

Baggage header should be lowercase #1967

Rast1234 opened this issue Apr 8, 2021 · 3 comments · Fixed by #2003
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Rast1234
Copy link

Rast1234 commented Apr 8, 2021

Bug Report

Currently BaggagePropagator works with header called Baggage:

        internal const string BaggageHeaderName = "Baggage";

Specification explicitly states that header name is baggage (all lowercase).

Currently propagator works for HTTP since headers are case-insensitive, but it can not be used as-is for, say, RabbitMQ. We have to do .ToLower() when getting or setting the value.

@Rast1234 Rast1234 added the bug Something isn't working label Apr 8, 2021
@kipwoker
Copy link
Contributor

There was also a similar conversation: dotnet/aspnetcore#28328

@cijothomas
Copy link
Member

Fixing this might be considered breaking behavior, but this can be treated as a bug in original release, and hence can be fixed.

@cijothomas
Copy link
Member

cijothomas commented Apr 20, 2021

Will do 1.1.0 release addressing this. (and not 1.0.1 hotfix) - As discussed in 4/20/2021 SIG Meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants