Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Jaeger tags based on spec #1513

Merged
merged 3 commits into from
Nov 12, 2020
Merged

Updating Jaeger tags based on spec #1513

merged 3 commits into from
Nov 12, 2020

Conversation

eddynaka
Copy link
Contributor

https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/sdk_exporters/jaeger.md#instrumentationlibrary

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@eddynaka eddynaka requested a review from a team November 12, 2020 00:06
@eddynaka eddynaka self-assigned this Nov 12, 2020
@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@6157364). Click here to learn what that means.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1513   +/-   ##
=========================================
  Coverage          ?   81.28%           
=========================================
  Files             ?      232           
  Lines             ?     6311           
  Branches          ?        0           
=========================================
  Hits              ?     5130           
  Misses            ?     1181           
  Partials          ?        0           
Impacted Files Coverage Δ
....Jaeger/Implementation/JaegerActivityExtensions.cs 96.06% <50.00%> (ø)

@cijothomas cijothomas merged commit be72b17 into open-telemetry:master Nov 12, 2020
@eddynaka eddynaka deleted the feature/updating-tags-based-spec branch November 12, 2020 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants