Updating Jaeger tags based on spec (#1513)

* Updating Jaeger tags based on spec * updating changelog Co-authored-by: Cijo Thomas <[email protected]>
open-telemetry · Nov 12, 2020 · be72b17 · be72b17
1 parent 6157364
commit be72b17
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/src/OpenTelemetry.Exporter.Jaeger/CHANGELOG.md b/src/OpenTelemetry.Exporter.Jaeger/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+* Jaeger tags used for InstrumentationLibrary changed from library.name,
+  library.version to otel.library.name, otel.library.version respectively.
+  ([#1513](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1513))
+
 ## 0.8.0-beta.1
 
 Released 2020-Nov-5

diff --git a/src/OpenTelemetry.Exporter.Jaeger/Implementation/JaegerActivityExtensions.cs b/src/OpenTelemetry.Exporter.Jaeger/Implementation/JaegerActivityExtensions.cs
@@ -95,10 +95,10 @@ public static JaegerSpan ToJaegerSpan(this Activity activity)
             var activitySource = activity.Source;
             if (!string.IsNullOrEmpty(activitySource.Name))
             {
-                PooledList<JaegerTag>.Add(ref jaegerTags.Tags, new JaegerTag("library.name", JaegerTagType.STRING, vStr: activitySource.Name));
+                PooledList<JaegerTag>.Add(ref jaegerTags.Tags, new JaegerTag("otel.library.name", JaegerTagType.STRING, vStr: activitySource.Name));
                 if (!string.IsNullOrEmpty(activitySource.Version))
                 {
-                    PooledList<JaegerTag>.Add(ref jaegerTags.Tags, new JaegerTag("library.version", JaegerTagType.STRING, vStr: activitySource.Version));
+                    PooledList<JaegerTag>.Add(ref jaegerTags.Tags, new JaegerTag("otel.library.version", JaegerTagType.STRING, vStr: activitySource.Version));
                 }
             }
 

diff --git a/test/OpenTelemetry.Exporter.Jaeger.Tests/Implementation/JaegerActivityConversionTest.cs b/test/OpenTelemetry.Exporter.Jaeger.Tests/Implementation/JaegerActivityConversionTest.cs
@@ -327,7 +327,7 @@ public void JaegerActivityConverterTest_ConvertActivityToJaegerSpan_NoLinks()
             // The last tag should be library.name in this case
             tag = tags[tags.Length - 1];
             Assert.Equal(JaegerTagType.STRING, tag.VType);
-            Assert.Equal("library.name", tag.Key);
+            Assert.Equal("otel.library.name", tag.Key);
             Assert.Equal(nameof(CreateTestActivity), tag.VStr);
 
             var logs = jaegerSpan.Logs.ToArray();