review use of lists #151
Merged
review use of lists #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-garcia
requested review from
austinlparker,
discostu105,
lmolkova and
SergeyKanzhelev
as code owners
|
Oh I see Is getting this to build on |
|
@bruno-garcia I think it'd be interesting, but I'm not sure how much work it'd be. I think if anything we'd prefer for something like full net45 on mono to be a bit later, once we've factored out all of the adapters and such. |
lmolkova
reviewed
Jul 16, 2019
|
@austinlparker It's done on this repo with .NET Framework reference assemblies and |
lmolkova
approved these changes
Jul 22, 2019
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to learn the codebase while tackling issue #62
Maybe I'm missing something but there aren't many public
List<T>in the API?