Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API review: IList sometimes is used in API surface where IEnumerable will suffice #62

Closed
SergeyKanzhelev opened this issue Jun 3, 2019 · 1 comment
Closed

API review: IList sometimes is used in API surface where IEnumerable will suffice #62

SergeyKanzhelev opened this issue Jun 3, 2019 · 1 comment
Labels
pkg:OpenTelemetry.Api Issues related to OpenTelemetry.Api NuGet package

Comments

@SergeyKanzhelev
Copy link
Member

See original issue: census-instrumentation/opencensus-csharp#64

Reviewing API surface - IList is used when IEnumerable will suffice. For instance in Exporter handler and other places. IList allows manipulating elements - add, remove, etc. when this is absolutely not the intent.
@SergeyKanzhelev SergeyKanzhelev added the pkg:OpenTelemetry.Api Issues related to OpenTelemetry.Api NuGet package label Jun 3, 2019
@SergeyKanzhelev SergeyKanzhelev added this to the API complete milestone Jun 3, 2019
@bruno-garcia bruno-garcia mentioned this issue Jul 15, 2019
Merged
@austinlparker
Copy link
Member

This appears to have been closed by #151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pkg:OpenTelemetry.Api Issues related to OpenTelemetry.Api NuGet package
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@austinlparker @SergeyKanzhelev