Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

IList sometimes is used in API surface where IEnumerable will suffice #64

Closed
SergeyKanzhelev opened this issue Nov 26, 2018 · 1 comment
Closed

IList sometimes is used in API surface where IEnumerable will suffice #64

SergeyKanzhelev opened this issue Nov 26, 2018 · 1 comment
Labels
enhancement good first issue OpenCensus.Abstractions API design issues up-for-grabs
Milestone
1904 - clean API

Comments

@SergeyKanzhelev
Copy link
Member

Reviewing API surface - IList is used when IEnumerable will suffice. For instance in Exporter handler and other places. IList allows manipulating elements - add, remove, etc. when this is absolutely not the intent.
This was referenced Dec 31, 2018
Merged
Merged
@SergeyKanzhelev SergeyKanzhelev mentioned this issue Jan 14, 2019
Merged
@SergeyKanzhelev SergeyKanzhelev added this to the 1904 - clean API milestone Jan 14, 2019
@SergeyKanzhelev SergeyKanzhelev added the OpenCensus.Abstractions API design issues label Feb 27, 2019
SergeyKanzhelev pushed a commit that referenced this issue Apr 3, 2019
@MirzaMerdovic @SergeyKanzhelev
Item #64 - Replace usage of IList or List with readonly collections w…
2f0e644 
…here possible/appropriate. (#135)
@SergeyKanzhelev SergeyKanzhelev mentioned this issue Jun 3, 2019
Closed
@SergeyKanzhelev
Copy link
Member Author

This will be handled in OpenTelemetry project

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement good first issue OpenCensus.Abstractions API design issues up-for-grabs
Projects
None yet
Milestone
1904 - clean API
Development

No branches or pull requests
1 participant
@SergeyKanzhelev