Forking the DataDog .NET Tracer to seed the OTel .NET In-Proc-Auto-Instrumentation-Agent. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…strumentation-Agent.
cijothomas
reviewed
Aug 19, 2020
.github/CODEOWNERS
Outdated
| @@ -0,0 +1 @@ | |||
| * @DataDog/apm-dotnet | |||
There was a problem hiding this comment.
are you planning to merge this as is? or do more cleanups before merge?
There was a problem hiding this comment.
As discussed in the SIG meeting, I want to merge as is to unblock others from contributing. However, I do plan to clean up subsequently.
cijothomas
reviewed
Aug 19, 2020
| Add any other context about the problem here. | ||
|
|
||
| <!-- | ||
| NOTE: To contact our support team, see https://www.datadoghq.com/support/ |
There was a problem hiding this comment.
Will you be removing all vendor specific contents?
|
I just did a clean-up of the DD code. I will close this and re-create a PR with cleaned up code shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initial seed for the official Open Telemetry .NET Tracer (aka in-process agent, aka auto-instrumentation agent).
We are doing this by merging the current master of https://github.com/DataDog/dd-trace-dotnet into an empty master of https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation.