-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test to ensure domain-neutral is working #1234
Add test to ensure domain-neutral is working #1234
Conversation
Tracking via #1235 Test failure on windows-2022 on GraphQL: https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/actions/runs/3062009532/jobs/4942479088#step:4:3381 Another run, another failure on this test: https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/actions/runs/3062693118/jobs/4945192191#step:4:3382 Failure on attempt #6: https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/actions/runs/3062693118/jobs/4947320069#step:4:3382 |
🤔 Hum, the strong name test failed on this run: https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/actions/runs/3062693118/jobs/4943951142#step:4:3392 I may need to add some synchronization to ensure that the span is exported and received. [Edit 09/16/22]: More failures of the same test, created #1242 |
Why
To ensure that domain-neutral instrumentation is not broke by unrelated changes.
It doesn't "fix" #1134 directly, however, after adding strong name support an assembly properly registered on the GAC can be loaded as domain-neutral for bytecode instrumentations. In light of that will close #1134 when this PR is merged.
What
Add a test to ensure domain-neutral bytecode instrumentation is working. Since domain-neutral depends on the assembly to be registered on the GAC and that requires strong name, the test is very similar to the strong name test recently added.
Tests
Added a new test:
DomainNeutralTests
.Checklist
- [ ]CHANGELOG.md
is updated.- [ ] Documentation is updated.- [ ] New features are covered by tests.