-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.NET9 support #3796
.NET9 support #3796
Conversation
drops .NET7 and .NET6
drops .NET6 and .NET7
It should be fixed just after next release
@stevejgordon, fyi |
Co-authored-by: Rasmus Kuusmann <[email protected]>
test/OpenTelemetry.AutoInstrumentation.Tests/TransientDependenciesTests.cs
Show resolved
Hide resolved
test/test-applications/integrations/TestApplication.Azure/TestApplication.Azure.csproj
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've looked through and overall it looks good. I'll wait for resolution on existing comments before approving
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are many places in the code where we needed to change NET60_OR_GREATER
to NET80_OR_GREATER
. It seems like the intent of the directive in many, if not most of those locations was to use a version of the code that only applied to the .net build target and not the .net framework build target.
Where appropriate, should we change NET80_OR_GREATER
to either NET
or !NETFRAMEWORK
, to make the intent clearer?
@nrcventura, I agree, but I do not want to make such changes in the same file. just kept the current convention. New issue created: #3798 (not a blocker to the release IMO, just normal maintenance task). |
test/IntegrationTests/BuildTests.DistributionStructure_alpine-linux-arm64.verified.txt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor things and tweaks only. In overall tests are passing, seems like good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Why
Towards #3766
What
Adds support for .NET9.
Drops support for .NET6 and .NET7.
Other related cleanup.
Bumping .NET SDK to
8.0.404
LangVersion
updated to 13 (version supported by .net 9). previous version was taken from .NET7 (needed for some genrated, grpc code).Tests
CI
Checklist
CHANGELOG.md
is updated.Newfeatures are covered by tests.Notes
dotnet format
is failing. Not related to changes.PR is huge, IMO worth to review commit by commit.