Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verrify TypeAttributes.Serializable in DuckTyping #3799

Closed
Kielek opened this issue Nov 21, 2024 · 1 comment · Fixed by #3840
Closed

Verrify TypeAttributes.Serializable in DuckTyping #3799

Kielek opened this issue Nov 21, 2024 · 1 comment · Fixed by #3840
Assignees
Milestone

Comments

@Kielek
Copy link
Contributor

Kielek commented Nov 21, 2024

The usage of TypeAttributes.Serializable seems to have been used since its introduction into the Datadog automatic instrumentation. I've messaged my colleagues to understand if it's truly needed, and if it is then we'll need to suppress this compiler warning. Or perhaps if it's not needed for newer runtimes we can ifdef its usage, but I don't know if that's the case

Originally posted by @zacharycmontoya in #3796 (comment)

It can be done after merge, it was working fine on .NET8 with .NET6 binaries for a while. No rush to changes.

@Kielek Kielek mentioned this issue Nov 21, 2024
3 tasks
@zacharycmontoya
Copy link
Contributor

I asked around with some colleagues at Datadog and the consensus is that there is risk in removing the attribute, but there's no clear scenario where the error could occur. To be safe, the recommendation is to keep applying the Serializable attribute on the generated types (keeping the code as-is).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants