Resolve file loading issues originating from Runtime store libraries #3343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@open-telemetry/dotnet-instrumentation-approvers Please review and test the behavior with Examples app in our repo. This approach resolves the crash issues that occur due to runtime store conflicts. Do set |
|
@rajkumar-rangaraj, could you please add CHANGELOG entry for this fix? I suppose it could convince some users to upgrade. |
pjanotti
approved these changes
Mar 29, 2024
There was a problem hiding this comment.
Very nice @rajkumar-rangaraj!
I will give a spin later today to validate some cases, but, at first LGTM. Per @Kielek comment a note on changelog will be good.
@Kielek Added changelog, please take a look. |
nrcventura
reviewed
Mar 29, 2024
nrcventura
approved these changes
Mar 29, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes #3168, #3075
Follow up #3187
Steps to recreate an issue:: Adding the below package reference to
Examples.AspNetCoreMvcproject for net6.0 target it will reproduce crash issue.What
The .NET loader takes control when the assembly load fails. If an assembly is part of the runtime store, we load it in a different context. This approach prevents crashes and allows ILogger data collection.
Rule engine needs to be turned off to test this approach. Diagnostics rule has a backoff logic.
Tests
Existing CI
Checklist
[ ]CHANGELOG.mdis updated.[ ] Documentation is updated.[ ] New features are covered by tests.