-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Diagnostic Logging for Runtime Store Assembly Version Validation #3187
Add Diagnostic Logging for Runtime Store Assembly Version Validation #3187
Conversation
We may need to hold on to this PR till 1.7 release. All the test apps that uses OpenTelemetry SDK fails. [2023-12-14T01:53:33.6364129Z] [Error] Rule Engine: Application has direct or indirect reference to lower version of runtime store assembly \opentelemetry-dotnet-instrumentation\bin\tracer-home\store\x64\net8.0\microsoft.extensions.configuration\8.0.0\lib\net8.0\Microsoft.Extensions.Configuration.dll - 3.100.19.56504. |
Will this problem just come up again when .net 9 is released next year? |
No. It should not impact with .NET 9 release. |
src/OpenTelemetry.AutoInstrumentation.StartupHook/RulesEngine/RuntimeStoreVersionRule.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.AutoInstrumentation.StartupHook/RulesEngine/RuntimeStoreVersionRule.cs
Outdated
Show resolved
Hide resolved
This PR is ready for review. PTAL. |
src/OpenTelemetry.AutoInstrumentation.StartupHook/RulesEngine/RuntimeStoreDiagnosticRule.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.AutoInstrumentation.StartupHook/RulesEngine/RuntimeStoreDiagnosticRule.cs
Show resolved
Hide resolved
It will be good to add a mention of it to the troubleshooting guide. |
Why
Addresses part of #3168, #3075 by adding logging about an issue.
Adding the below package reference to
Examples.AspNetCoreMvc
project for net6.0 target it will recreate crash issue.What
This rule logs diagnostic messages about the assembly versions in the runtime store compared to the application's assembly versions. It is designed to inform rather than enforce, ensuring that any potential versioning issues are noted without affecting the runtime behavior of the application.
Example:
Tests
Checklist
[ ]CHANGELOG.md
is updated.[ ] Documentation is updated.[ ] New features are covered by tests.