MongoDB - instrumenation for .NET Framework

[Kielek]

Why

Fixes #2328

What

• MongoDB - instrumentation for .NET Framework
• Move instrumentation library dependency from Addition Dependencies to main project.

Tests

Executed locally on Docker for Windows with Linux.
Testocontainers for now does not support Docker for Windows with Windows. No possibility to enable it in pipeline: testcontainers/moby-ryuk#40 (comment)

Checklist

• CHANGELOG.md is updated.
• Documentation is updated.
• New features are covered by tests.

[Kielek]

Alternative approach discussed with @RassK - manually copy MongoDB instrumentation library instead of removing non-needed libraries from the output folder.

As the goal, for now, is to make nuget scenario working (+ .NET Framework support) I would keep current scenario. Proposal from Rasmus can be handled later as future optimisations.

[RassK]

Alternative approach discussed with @RassK - manually copy MongoDB instrumentation library instead of removing non-needed libraries from the output folder.

As the goal, for now, is to make nuget scenario working (+ .NET Framework support) I would keep current scenario. Proposal from Rasmus can be handled later as future optimisations.

This will also halt the huge progress made in #2294. Meanwhile @pjanotti's suggestion for Nuget is also easier to achieve.

[Kielek]

@RassK, I think that #2294 can be adapted also to direct references approach. Now, ExcludedAssets are generated manually.

[RassK]

@RassK, I think that #2294 can be adapted also to direct references approach. Now, ExcludedAssets are generated manually.

No, it's only addressed for additional deps / shared store purpose.
(designed for loosely coupled dependencies, instead of direct dependencies)

[Kielek]

Potential follow up commit with nuget support: Kielek@4cf165e

[pjanotti]

@Kielek @RassK this PR is an interesting possible path forward for the "usual" distribution (ie.: non-Nuget). That said I think we have to step back and design the overall solution.

Regarding:

Testocontainers for now does not support Docker for Windows with Windows. No possibility to enable it in pipeline: testcontainers/moby-ryuk#40 (comment)

I thought the issue was that GH Windows runners can only run Windows containers. The ASP.NET test launches a Windows container without the ryuk stuff. That said it is true that ryuk launches a Linux container. If we want to test MongoDB instrumentation on .NET Framework it will be necessary to run MongoDB in a Windows container.

[RassK]

@Kielek @RassK this PR is an interesting possible path forward for the "usual" distribution (ie.: non-Nuget). That said I think we have to step back and design the overall solution.

For me it seems to be in any way step backwards.

• It's a complex package (many dependencies + native dependencies)
• It has dependencies not connected to MongoDB (DnsClient and SharpCompress)
• I think we should be more dynamic and adaptive to the application, than more static and ship a relatively large package.
• Being static narrows down the supported version range. Currently it's theoretically possible to extend the support by having multiple versions of the adapter module and then dynamically loading the correct version.

[theletterf]

@Kielek LMK when this goes downstream—thx!

[pjanotti]

LGTM w/ a minor suggestion.

[pjanotti]

To avoid the verbosity and the copy/paste mistake it seems better to have a single comment before the ItemGroup. Something like "Transient dependencies from MongoDB.Driver.Core.Extensions.DiagnosticSources that are shipped with the applications. ExcludeAssets="all" prevents copying them to the output"

[Kielek]

Extracted common comment. b7ca218
I would keep explanation per library - I expect more to come. Part of them probably can be linked by more than one library.