-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document libraries in the store #1380
Comments
Check with #1382 |
After a long investigation, seems there is no point to document these concrete dependencies. Also I think this doc should be generated automatically somehow. The only important dependencies to write down extra are the ones potentially crashing the application (tests are anyway tracking the whole output). |
I agree that we should sheep only MongoDB.Driver.Core.Extensions.DiagnosticSources but no other indirect dependencies. Do you see any other similar issues? Or maybe the way how to automatically detect them? Automatically generated documentation could be done in scope of this issue. |
I guess (or hope) that even To do it automatically we have to take apart packages we support,
The hardest part is to understand how .NET is choosing to upgrade versions, when multiple transient dlls have similar childs. If this is resolved, we can auto list all conflicting libs to the doc. According to my manual tests, the biggest issue is |
I think this is important to be done soon. That said the current scale of the issue allows us to postpone fully automating the solution. I also want to think about how this can impact the NuGet work that we are starting. |
Probably need to wait for #1213, it's output is important. I'm thinking to take TestApplications as a base to analyse supported instrumentations output (dlls) but this means TestApplications must be strictly using nothing extra. So far seems, these follow the rule. Edit: #2223 has also significant effect on this issue. |
Might need to start documenting possible conflicting dependencies.
I see it brings 3 new dependencies >
More worried about the last 2.
Originally posted by @RassK in #1320 (comment)
The text was updated successfully, but these errors were encountered: