Reduce shared store size on roll forward #2223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjanotti
commented
Feb 18, 2023
| @@ -499,41 +500,17 @@ void CopyNativeDependenciesToStore(AbsolutePath file, JsonDocument jsonDocument, | |||
| } | |||
| } | |||
|
|
|||
| void RemoveDuplicatedLibraries(string depsJsonContent, IReadOnlyList<string> architectureStores) | |||
| { | |||
| var duplicatedLibraries = new List<(string Name, string Version)> { }; | |||
There was a problem hiding this comment.
Removed this function because due to this line, it was never deleting anything.
pellared
approved these changes
Feb 20, 2023
Kielek
approved these changes
Feb 20, 2023
RassK
approved these changes
Feb 20, 2023
Kielek
added a commit
that referenced
this pull request
Jun 15, 2023
…2654) * Bump Microsoft.Extensions.Logging.Abstractions from 7.0.0 to 7.0.1 Bumps [Microsoft.Extensions.Logging.Abstractions](https://github.com/dotnet/runtime) from 7.0.0 to 7.0.1. - [Release notes](https://github.com/dotnet/runtime/releases) - [Commits](dotnet/runtime@v7.0.0...v7.0.1) --- updated-dependencies: - dependency-name: Microsoft.Extensions.Logging.Abstractions dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Fix build process after upgrade partially revert RemoveDuplicatedLibraries functionality from #2223 and #1226 --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Piotr Kiełkowicz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Reduces the size of the shared store for net6.0
Fixes #2180
What
Update the deps.json to point to the roll forward TFM and delete the TFM directory that becomes unused.
Tests
Already covered via DotNetCliTests and Integration tests in general.
Checklist
- []CHANGELOG.mdis updated.- [] Documentation is updated.- [] New features are covered by tests.