Configurable log level - native code and loader #2288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lachmatt
commented
Mar 6, 2023
| { | ||
| m_fileout = spdlog::rotating_logger_mt("Logger", GetLogPath(file_name_suffix), 1048576 * 5, 10); |
There was a problem hiding this comment.
I will make size configurable with OTEL_DOTNET_AUTO_LOG_FILE_SIZE in a separate PR.
lachmatt
commented
Mar 6, 2023
| // By writing into the stderr was changing the behavior in a CI scenario. | ||
| // There's not a good way to report errors when trying to create the log file. | ||
| // But we never should be changing the normal behavior of an app. | ||
| // std::cerr << "LoggerImpl Handler: Error creating native log file." << std::endl; | ||
| m_fileout = spdlog::null_logger_mt("LoggerImpl"); |
There was a problem hiding this comment.
Filtering out in sink yields simpler implementation (compared to tracking if logLevel is enabled in LoggerImpl before forwarding to sinks), but results in overhead of LogToString conversion which might not be needed. Let me know if I should address that in a separate PR.
There was a problem hiding this comment.
I'm in favor of adding it in a separate PR: it is typical for log systems to avoid extra work depending on the log level. That's why the log levels are usually treated as comparable integers.
pellared
reviewed
Mar 6, 2023
pellared
reviewed
Mar 6, 2023
pellared
reviewed
Mar 6, 2023
pjanotti
reviewed
Mar 6, 2023
src/OpenTelemetry.AutoInstrumentation.Loader/Loader.NetFramework.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.AutoInstrumentation.Loader/OpenTelemetry.AutoInstrumentation.Loader.csproj
Show resolved
Hide resolved
lachmatt
force-pushed
the
configurable-log-level-in-native
branch
from
76621d9 to
8a2f5f3
Compare
Kielek
approved these changes
Mar 7, 2023
pjanotti
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Towards #2183
Fixes #372
What
Handle configured
OTEL_LOG_LEVELin native code and loader.OTEL_LOG_LEVELvalue, or usenull_sinkifnoneis configured- Removed benchmarks of removed(update: split into DropLoaderLoggerLoaderLoggerbenchmarks #2289 )Tests
Checklist
CHANGELOG.mdis updated.- [ ] New features are covered by tests.