Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log issues in auto instrumentation #2183

Closed
muhaook opened this issue Feb 9, 2023 · 4 comments
Closed

log issues in auto instrumentation #2183

muhaook opened this issue Feb 9, 2023 · 4 comments
Assignees
Milestone

Comments

@muhaook
Copy link

muhaook commented Feb 9, 2023

Bug Report

3 issues about log in auto instrumentation:

  • debug is always on
    ideally, it is configurable to switch on/off of debug level in logging.
  • logging is stopped after log file size reached 10 MB
    we probably need a rotation mechanism so that logging can continue after reaching a file size limit.
  • log file clean up
    there will be a lot of log files after applications keep running for a long time. we probably need a clean up mechanism based on retention policies.
@pellared
Copy link
Member

pellared commented Feb 9, 2023

Related issues:

@pjanotti
Copy link
Contributor

pjanotti commented Feb 16, 2023

Adding support to disable logging via something like #372 seems a good idea. That said there are a few issues opened related to our logging. It seems a good opportunity to define a small plan instead of taking incremental changes. The top Q that we have to decide is if we should adopt the same mechanism as the SDK. If yes, what about native .NET Framework logging?

@Kielek
Copy link
Contributor

Kielek commented Mar 13, 2023

First post 0.6.0 version should contains all changed.

@lachmatt
Copy link
Contributor

All of the requirements should be met:

  • logLevel is configurable using OTEL_LOG_LEVEL
  • rotation mechanism is in place
  • max 10 log files should be retained

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

6 participants