Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logfile size is limited #469

Closed
pellared opened this issue Apr 11, 2022 · 4 comments
Closed

Logfile size is limited #469

pellared opened this issue Apr 11, 2022 · 4 comments
Assignees
Milestone

Comments

@pellared
Copy link
Member

Currently, after the logfile reaches the hardcoded size, no more logs are appended.

Possible options:

  1. Make file size configurable (-1 can mean unbounded)
  2. Add logfile rolling
  3. Add logfile rotation
    Add rolling or rotation for logfiles.

Originally posted by @pellared in #456 (comment)

@pellared
Copy link
Member Author

pellared commented Apr 20, 2022

SIG meeting:

@lachmatt is proposing "logfile rotation" as a followup
@pjanotti mentioned that they may be a name conflict if PID is used in the file name (PID can be reused). PID + timestamp should be good enough

@pellared pellared added this to the 1.0.0-rc milestone Apr 20, 2022
@pellared pellared modified the milestones: 1.0.0-rc, 0.2.1-beta May 11, 2022
@pellared
Copy link
Member Author

Maybe we should use OTel SDK's self-diagnostics for logging in order not to reinvent the wheel?

@pellared
Copy link
Member Author

Closing per #959 and #960

@Kielek
Copy link
Contributor

Kielek commented Mar 13, 2023

Fixed by @lachmatt in few latest PRs related to logging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants