-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure ./run-example.sh adds bytecode instr. #1383
Ensure ./run-example.sh adds bytecode instr. #1383
Conversation
Ok, adding the logs receiver to the collector got rid of this error message:
However, there are still the following warning messages:
Tracking the warning messages via #1384 |
@@ -32,11 +25,15 @@ exporters: | |||
service: | |||
pipelines: | |||
traces: | |||
receivers: [otlp, jaeger, zipkin] | |||
receivers: [otlp] | |||
processors: [batch] | |||
exporters: [jaeger, logging] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jaeger supports OTLP by default. We should be able to drop jaeger protocol here.
Probably separate PR. Ref: https://www.jaegertracing.io/docs/1.38/apis/#opentelemetry-protocol-stable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should change the examples
to just contain a client and server app, Dockerfiles, and a docker-compose to run it.
Previously we used it for testing purposes. Right now I think we should make it more .NET devs (users) friendly.
Why
Bytecode instrumentation is not available when running ./run-example.sh
What
dev/envvars.sh
configurable and preventdotnet.exe
anddotnet
from being excluded when running ./run-example.shvendorPluginTargetFramework
on./run-example.sh
Tests
Ran
./run-example.sh
manually.Checklist
- [ ]CHANGELOG.md
is updated.- [ ] Documentation is updated.- [ ] New features are covered by tests.