Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure ./run-example.sh adds bytecode instr. #1383

Merged

Conversation

pjanotti
Copy link
Contributor

@pjanotti pjanotti commented Oct 7, 2022

Why

Bytecode instrumentation is not available when running ./run-example.sh

What

  • Make 3 env vars from dev/envvars.sh configurable and prevent dotnet.exe and dotnet from being excluded when running ./run-example.sh
  • Fixed vendorPluginTargetFramework on ./run-example.sh
  • Enabled logs on the collector config script, avoids errors being logged from processes exporting logs.

Tests

Ran ./run-example.sh manually.

Checklist

- [ ] CHANGELOG.md is updated.
- [ ] Documentation is updated.
- [ ] New features are covered by tests.

@pjanotti pjanotti requested a review from a team October 7, 2022 20:02
@pjanotti
Copy link
Contributor Author

pjanotti commented Oct 9, 2022

Ok, adding the logs receiver to the collector got rid of this error message:

[2022-10-09T20:14:29.7790596Z] [Error] EventSource=OpenTelemetry-Exporter-OpenTelemetryProtocol, Message=Exporter failed send data to collector to http://localhost:4318/v1/logs endpoint. Data will not be sent. Exception: System.Net.Http.HttpRequestException: Response status code does not indicate success: 404 (Not Found).
   at System.Net.Http.HttpResponseMessage.EnsureSuccessStatusCode()
   at OpenTelemetry.Exporter.OpenTelemetryProtocol.Implementation.ExportClient.BaseOtlpHttpExportClient`1.SendExportRequest(TRequest request, CancellationToken cancellationToken) 

However, there are still the following warning messages:

[2022-10-09T21:18:16.9526464Z] [Warning] EventSource=OpenTelemetry-Exporter-OpenTelemetryProtocol, Message=Could not translate LogRecord due to Exception: 'IFeatureCollection has been disposed.
Object name: 'Collection'.'. Log will not be exported. 
[2022-10-09T21:18:16.9589612Z] [Warning] EventSource=OpenTelemetry-Exporter-OpenTelemetryProtocol, Message=Could not translate LogRecord due to Exception: 'IFeatureCollection has been disposed.
Object name: 'Collection'.'. Log will not be exported. 
[2022-10-09T21:18:16.9596958Z] [Warning] EventSource=OpenTelemetry-Exporter-OpenTelemetryProtocol, Message=Could not translate LogRecord due to Exception: 'IFeatureCollection has been disposed.
Object name: 'Collection'.'. Log will not be exported. 
[2022-10-09T21:18:16.9605245Z] [Warning] EventSource=OpenTelemetry-Exporter-OpenTelemetryProtocol, Message=Could not translate LogRecord due to Exception: 'IFeatureCollection has been disposed.
Object name: 'Collection'.'. Log will not be exported. 
[2022-10-09T21:18:16.9612851Z] [Warning] EventSource=OpenTelemetry-Exporter-OpenTelemetryProtocol, Message=Could not translate LogRecord due to Exception: 'IFeatureCollection has been disposed.
Object name: 'Collection'.'. Log will not be exported. 
[2022-10-09T21:18:16.9620372Z] [Warning] EventSource=OpenTelemetry-Exporter-OpenTelemetryProtocol, Message=Could not translate LogRecord due to Exception: 'IFeatureCollection has been disposed.
Object name: 'Collection'.'. Log will not be exported. 

Tracking the warning messages via #1384

@@ -32,11 +25,15 @@ exporters:
service:
pipelines:
traces:
receivers: [otlp, jaeger, zipkin]
receivers: [otlp]
processors: [batch]
exporters: [jaeger, logging]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jaeger supports OTLP by default. We should be able to drop jaeger protocol here.

Probably separate PR. Ref: https://www.jaegertracing.io/docs/1.38/apis/#opentelemetry-protocol-stable

Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should change the examples to just contain a client and server app, Dockerfiles, and a docker-compose to run it.

Previously we used it for testing purposes. Right now I think we should make it more .NET devs (users) friendly.

@pellared pellared mentioned this pull request Oct 10, 2022
@pellared pellared merged commit 83ed469 into open-telemetry:main Oct 10, 2022
@pjanotti pjanotti deleted the run-example-should-add-bytecode-instr branch October 10, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants