Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recreate /examples #1388

Closed
pellared opened this issue Oct 10, 2022 · 3 comments · Fixed by #1708 or #1882
Closed

Recreate /examples #1388

pellared opened this issue Oct 10, 2022 · 3 comments · Fixed by #1708 or #1882
Assignees
@pellared
Milestone
0.6.0

Comments

@pellared
Copy link
Member

I think we should change the examples to just contain a client and server app, Dockerfiles, and a docker-compose to run it.

Previously we used it for testing purposes. Right now I think we should make it more .NET devs (users) friendly.

Originally posted by @pellared in #1383 (review)
@nrcventura nrcventura added this to the 0.5.0-beta milestone Oct 12, 2022
@pellared pellared modified the milestones: 0.5.0-beta, 0.6.0-beta, 0.7.1, 0.7.0 Nov 16, 2022
@pjanotti pjanotti mentioned this issue Nov 29, 2022
Closed
@pjanotti
Copy link
Contributor

Right now there are two instrument.sh scripts on the repo. While refactoring the examples we should look into keeping a single one, see #1681 (comment)

@pellared pellared self-assigned this Nov 29, 2022
@pellared pellared mentioned this issue Nov 29, 2022
Closed
@pellared pellared modified the milestones: 0.5.2, 0.5.1 Nov 29, 2022
@pellared
Copy link
Member Author

pellared commented Dec 1, 2022

TODO: Check #1694 when working on this issue.

@pellared pellared mentioned this issue Dec 5, 2022
Merged
3 tasks
@pellared
Copy link
Member Author

pellared commented Dec 7, 2022

TODO: Bring back the AspNetCoreMvc example.

@pellared pellared reopened this Dec 7, 2022
This was referenced Dec 30, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pellared pellared

Labels
None yet
Projects
OpenTelemetry .NET Automatic Instrumentation
Archived in project
Milestone
0.6.0
3 participants
@pellared @pjanotti @nrcventura