-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AzureMonitor] Change drop sampling result to recordOnly #933
[AzureMonitor] Change drop sampling result to recordOnly #933
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #933 +/- ##
==========================================
- Coverage 68.38% 68.38% -0.01%
==========================================
Files 183 183
Lines 7026 7025 -1
==========================================
- Hits 4805 4804 -1
Misses 2221 2221
|
…/github.com/vishweshbankwar/opentelemetry-dotnet-contrib into vibankwa/update-applicationinsights-sampler
Changes looks good, but it will be great to include some explanation why it is needed (maybe first comment in the PR?). |
@Kielek I was curious too so I chatted with @vishweshbankwar about this. This sampling behavior matches what AppInsights does today so it is about bringing parity for those customers moving to OTel. |
Fixes #.
Changes
Sampler will now return
RecordOnly
SamplingResult when the telemetry is sampled instead ofDrop
. This will result activity object to be created always and populated with all information such as tag, events etc. This is done in order to allow standardmetrics collection from the generated activities.
The change is needed in order to provide feature parity to current Application Insights SDK customers moving to OpenTelemetry.
Note: This change will have no impact on the overall sampling behavior.
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes