Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom BatchExportProcessor to support standard metrics #33715

Closed
wants to merge 2 commits into from

Conversation

vishweshbankwar
Copy link
Contributor

@vishweshbankwar vishweshbankwar commented Jan 27, 2023

Updating trace exporter to use the custom BatchExportProcessor to let all activities pass on to exporter. This will enable accurate standard metric collection on the exporter side. Activities with Recorded=false will be filtered out on the exporter side to prevent sampledOut activities to get transmitted to backend.

Custom ApplicationInsights sampler will also be updated to return RecordOnly SamplingResult instead of Drop when the samplers decision is to drop the telemetry. This will allow activities to be enriched by instrumentation libraries (This is needed for setting dimensions on standard metrics) and also allow correct traceflags(traceparent header) to be transmitted to downstream services.

Vishwesh Bankwar added 2 commits January 27, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant