Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.Runtime] Enable nullable #893

Merged
merged 6 commits into from
Jan 20, 2023

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Jan 12, 2023

Towards #894

Changes

Nullable for Runtime projects.

For significant contributions please make sure you have completed the following items:

  • [ ] Appropriate CHANGELOG.md updated for non-trivial changes
  • [ ] Design discussion issue #

@Kielek Kielek marked this pull request as ready for review January 12, 2023 13:01
@Kielek Kielek requested a review from a team January 12, 2023 13:01
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #893 (94e875d) into main (b53b6b9) will decrease coverage by 0.06%.
The diff coverage is 81.81%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #893      +/-   ##
==========================================
- Coverage   68.48%   68.42%   -0.06%     
==========================================
  Files         183      183              
  Lines        7002     7006       +4     
==========================================
- Hits         4795     4794       -1     
- Misses       2207     2212       +5     
Impacted Files Coverage Δ
...entation.Process/MeterProviderBuilderExtensions.cs 85.71% <50.00%> (-14.29%) ⬇️
...entation.Runtime/MeterProviderBuilderExtensions.cs 87.50% <50.00%> (-12.50%) ⬇️
...elemetry.Instrumentation.Runtime/RuntimeMetrics.cs 100.00% <100.00%> (ø)
...trumentation.EventCounters/EventCountersMetrics.cs 75.90% <0.00%> (-3.62%) ⬇️

@Kielek Kielek added the comp:instrumentation.runtime Things related to OpenTelemetry.Instrumentation.Runtime label Jan 12, 2023
@Kielek
Copy link
Contributor Author

Kielek commented Jan 19, 2023

Fix for failing test potentially in #897

@alanwest alanwest merged commit 5bd14dc into open-telemetry:main Jan 20, 2023
@Kielek Kielek deleted the nullabe-runtime-metrics branch January 20, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.runtime Things related to OpenTelemetry.Instrumentation.Runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants