[Instrumentation.Process] Enable nullable #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kielek
added
the
comp:instrumentation.process
TimothyMothra
approved these changes
Jan 12, 2023
|
@Kielek I would encourage you to create an Issue to track all of these individual PRs. :) |
alanwest
reviewed
Jan 17, 2023
| @@ -33,7 +33,7 @@ public static class MeterProviderBuilderExtensions | |||
| /// <returns>The instance of <see cref="MeterProviderBuilder"/> to chain the calls.</returns> | |||
| public static MeterProviderBuilder AddProcessInstrumentation( | |||
| this MeterProviderBuilder builder, | |||
| Action<ProcessInstrumentationOptions> configure = null) | |||
| Action<ProcessInstrumentationOptions>? configure = null) | |||
There was a problem hiding this comment.
Same story here... #893 (comment)
Kielek
force-pushed
the
nullabe-process-metrics
branch
from
8c6a409
to
3018230
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #892 +/- ##
==========================================
- Coverage 68.48% 68.43% -0.05%
==========================================
Files 183 183
Lines 7002 7004 +2
==========================================
- Hits 4795 4793 -2
- Misses 2207 2211 +4
|
alanwest
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #894
Changes
Nullable for Process project.
For significant contributions please make sure you have completed the following items:
[ ] AppropriateCHANGELOG.mdupdated for non-trivial changes[ ] Design discussion issue #