Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Exporter.Geneva] Update GenevaTraceExporter #871

Merged
merged 2 commits into from
Jan 5, 2023
Merged

[Exporter.Geneva] Update GenevaTraceExporter #871

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6de4c8e
Update GenevaTraceExporter
utpilla Jan 5, 2023
8bc2fa1
Merge branch 'main' into utpilla/Update-GenevaTraceExporter
utpilla Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/OpenTelemetry.Exporter.Geneva/MsgPackExporter/MsgPackTraceExporter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
using System;
using System.Collections.Generic;
using System.Diagnostics;
using System.Globalization;
using System.Runtime.InteropServices;
using System.Threading;

Expand Down Expand Up @@ -286,7 +287,7 @@ internal int SerializeActivity(Activity activity)
}
else if (string.Equals(entry.Key, "otel.status_code", StringComparison.Ordinal))
{
if (string.Equals(entry.Value.ToString(), "ERROR", StringComparison.Ordinal))
if (string.Equals(Convert.ToString(entry.Value, CultureInfo.InvariantCulture), "ERROR", StringComparison.Ordinal))
{
isStatusSuccess = false;
}
Expand All @@ -295,7 +296,7 @@ internal int SerializeActivity(Activity activity)
}
else if (string.Equals(entry.Key, "otel.status_description", StringComparison.Ordinal))
{
statusDescription = entry.Value.ToString();
statusDescription = Convert.ToString(entry.Value, CultureInfo.InvariantCulture);
continue;
}
else if (this.m_customFields == null || this.m_customFields.ContainsKey(entry.Key))
Expand Down