Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Exporter.Geneva] Update GenevaTraceExporter #871

Merged
merged 2 commits into from
Jan 5, 2023
Merged

[Exporter.Geneva] Update GenevaTraceExporter #871

merged 2 commits into from
Jan 5, 2023

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Jan 5, 2023

Changes

  • Fix potential NullReferenceException thrown when the values for the tags otel.status_code and otel.status_description is null

@utpilla utpilla requested a review from a team January 5, 2023 21:27
@utpilla utpilla added the comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva label Jan 5, 2023
@github-actions github-actions bot requested a review from CodeBlanch January 5, 2023 22:35
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #871 (8bc2fa1) into main (a10f287) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #871   +/-   ##
=======================================
  Coverage   79.07%   79.07%           
=======================================
  Files         182      182           
  Lines        5614     5614           
=======================================
  Hits         4439     4439           
  Misses       1175     1175
Impacted Files Coverage Δ
...ter.Geneva/MsgPackExporter/MsgPackTraceExporter.cs 92.92% <100.00%> (ø)

@utpilla utpilla merged commit 70f9f0f into open-telemetry:main Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cijothomas cijothomas Awaiting requested review from cijothomas

@mic-max mic-max Awaiting requested review from mic-max

@reyang reyang Awaiting requested review from reyang

@Yun-Ting Yun-Ting Awaiting requested review from Yun-Ting

@CodeBlanch CodeBlanch Awaiting requested review from CodeBlanch

Assignees

@cijothomas cijothomas

@mic-max mic-max

@Yun-Ting Yun-Ting

@reyang reyang

@CodeBlanch CodeBlanch

@utpilla utpilla

Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@utpilla @CodeBlanch @cijothomas @mic-max @Yun-Ting @reyang