Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instana exporter span duration fix #376

Merged
merged 7 commits into from
May 27, 2022
Merged

Instana exporter span duration fix #376

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3dcb1d3
Span duration was not calculated correctly
zivaninstana May 24, 2022
dacb243
Update CHANGELOG.md
zivaninstana May 24, 2022
5fb29f0
Instana Exporter - Markdown check fix
zivaninstana May 25, 2022
d5b6f55
Merge branch 'main' into instana_exporter_span_duration_fix
cijothomas May 25, 2022
32c13b5
Add pull request link to changelog
zivaninstana May 26, 2022
36adce4
Merge branch 'instana_exporter_span_duration_fix' of https://github.c…
zivaninstana May 26, 2022
d38b50e
Merge branch 'main' into instana_exporter_span_duration_fix
cijothomas May 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/OpenTelemetry.Exporter.Instana/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

## 1.0.1 [2022-May-25]

Instana span duration was not calculated correctly
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’d be nice to change the msg to say fixes an issue where …


## 1.0.0 [2022-May-24]

This is the first release of the `OpenTelemetry.Exporter.Instana`
Expand Down
2 changes: 1 addition & 1 deletion src/OpenTelemetry.Exporter.Instana/Implementation/InstanaSpanSerializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ internal async Task SerializeToStreamWriterAsync(InstanaSpan instanaSpan, Stream
await writer.WriteAsync(COMMA);
await this.AppendPropertyAsync(DateToUnixMillis(instanaSpan.Ts), "ts", writer);
await writer.WriteAsync(COMMA);
await this.AppendPropertyAsync(instanaSpan.D, "d", writer);
await this.AppendPropertyAsync((long)(instanaSpan.D / 10_000), "d", writer);
await writer.WriteAsync(COMMA);
await this.AppendObjectAsync(this.SerializeDataAsync, "data", instanaSpan, writer);
await writer.WriteAsync(COMMA);
Expand Down