Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instana exporter span duration fix #376

Merged

Conversation

zivaninstana
Copy link
Contributor

No description provided.

@zivaninstana zivaninstana requested a review from a team May 25, 2022 08:53
@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #376 (d38b50e) into main (827eb25) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #376   +/-   ##
=======================================
  Coverage   22.36%   22.36%           
=======================================
  Files         148      148           
  Lines        4533     4533           
=======================================
  Hits         1014     1014           
  Misses       3519     3519           
Impacted Files Coverage Δ
...er.Instana/Implementation/InstanaSpanSerializer.cs 0.00% <0.00%> (ø)

@@ -2,6 +2,10 @@

## Unreleased

## 1.0.1 [2022-May-25]

Instana span duration was not calculated correctly
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’d be nice to change the msg to say fixes an issue where …

@cijothomas cijothomas merged commit 21f73d3 into open-telemetry:main May 27, 2022
NathanielRN pushed a commit to NathanielRN/opentelemetry-dotnet-contrib that referenced this pull request Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants