Allow serialization of Unicode characters for Exception type #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
assigned cijothomas, CodeBlanch, mic-max, reyang, utpilla and Yun-Ting
github-actions
bot
requested review from
cijothomas,
CodeBlanch,
mic-max,
reyang and
Yun-Ting
Codecov Report
@@ Coverage Diff @@
## main #375 +/- ##
=======================================
Coverage 22.36% 22.36%
=======================================
Files 148 148
Lines 4533 4533
=======================================
Hits 1014 1014
Misses 3519 3519
|
cijothomas
approved these changes
May 25, 2022
reyang
reviewed
May 25, 2022
test/OpenTelemetry.Exporter.Geneva.Tests/GenevaLogExporterTests.cs
Outdated
Show resolved
Hide resolved
reyang
requested changes
May 25, 2022
There was a problem hiding this comment.
I just realized that many source files in this repo use UTF-8 BOM, probably worth considering some improvements (many tools don't work well with non-ASCII characters in the source code - e.g. low level debuggers, old fashioned terminal). This doesn't have to block the PR.
The blocker is https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/375/files#r881894745.
reyang
approved these changes
May 26, 2022
utpilla
added
the
comp:exporter.geneva
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing the issue mentioned here: #345 (comment)
Changes
SerializeUnicodeStringmethod to serializeLogRecord.Exception.GetType().FullNameFor significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes