-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PassThru TableNameMappings using the logger category name. #345
Conversation
Codecov Report
@@ Coverage Diff @@
## main #345 +/- ##
==========================================
+ Coverage 21.96% 22.70% +0.74%
==========================================
Files 144 144
Lines 4421 4465 +44
==========================================
+ Hits 971 1014 +43
- Misses 3450 3451 +1
|
test/OpenTelemetry.Exporter.Geneva.Tests/GenevaLogExporterTests.cs
Outdated
Show resolved
Hide resolved
test/OpenTelemetry.Exporter.Geneva.Tests/GenevaLogExporterTests.cs
Outdated
Show resolved
Hide resolved
test/OpenTelemetry.Exporter.Geneva.Benchmark/LogExporterTableMappingsBenchmarks.cs
Outdated
Show resolved
Hide resolved
test/OpenTelemetry.Exporter.Geneva.Benchmark/Exporter/LogExporterTableMappingsBenchmarks.cs
Outdated
Show resolved
Hide resolved
test/OpenTelemetry.Exporter.Geneva.Tests/GenevaLogExporterTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with some suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a changelog entry.
Related to:
#289
When the PassThruTableNameMappings rule was enable, the best fit table name given the category name were being generated while serializing each LogRecord.
Next steps:
Add benchmarks to compare perf w/ and w/o cache.
[Not for merging] Benchmarks for PassThruTableMappings. Yun-Ting/opentelemetry-dotnet-contrib#1
PassThru TableNameMappings using the logger category name. #288 (comment)
Document use cases for this feature. => Will be addressed in a follow-up PR.
Add testcase for Linux environment.
Determine the behavior of
Sanitize
when the category name is invalid. => When the category name is invalid, eventName will be assigned as null. GenevaExporter will not pick up events with null eventNames.