Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo/Geneva] Prepare to .NET9 #2342

Merged
merged 42 commits into from
Nov 22, 2024
Merged
Changes from 1 commit
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
80ef57a
Fix IDE0300/IDE0301
Kielek Nov 21, 2024
985dd43
Fix IDE0200
Kielek Nov 21, 2024
42fcd57
Fix IDE0078
Kielek Nov 21, 2024
71cf108
Fix IDE0007
Kielek Nov 21, 2024
b7002fa
Fix IDE0028
Kielek Nov 21, 2024
4535e6d
Fix IDE0025
Kielek Nov 21, 2024
02467e8
Fix IDE0036
Kielek Nov 21, 2024
d1ffd67
Fix IDE0078
Kielek Nov 21, 2024
9d6db0f
Fix IDE0048
Kielek Nov 21, 2024
228c3b3
Fix IDE0004
Kielek Nov 21, 2024
a61ba13
Fix IDE0010
Kielek Nov 21, 2024
86436e7
Fix IDE0066
Kielek Nov 21, 2024
1c18d98
Fix IDE0045/IDE0046
Kielek Nov 21, 2024
84fe472
Fix IDE0230
Kielek Nov 21, 2024
40364c6
Benchmarks - Fix IDE0300
Kielek Nov 21, 2024
1a04f0e
Benchmarks - Fix IDE0090
Kielek Nov 21, 2024
7d06307
Benchmarks - Fix IDE0007
Kielek Nov 21, 2024
638f0ea
Benchmarks - Fix IDE0017
Kielek Nov 21, 2024
c33c00f
Benchmarks - Fix IDE0044
Kielek Nov 21, 2024
def2108
Benchmarks - Fix/disable CA1515
Kielek Nov 21, 2024
faa2c2c
Benchmarks - Fix IDE0052
Kielek Nov 21, 2024
b9af64b
Stress
Kielek Nov 21, 2024
02f38aa
Tests - Fix IDE0300
Kielek Nov 21, 2024
96958f1
Tests - Fix IDE0305
Kielek Nov 21, 2024
91b3a52
Fix IDE0078
Kielek Nov 21, 2024
0c4a930
Tests - Fix IDE0017
Kielek Nov 21, 2024
e38632c
Tests - Fix IDE0028
Kielek Nov 21, 2024
c8379ba
Tests - Fix IDE0090
Kielek Nov 21, 2024
09c7949
Fix IDE0010
Kielek Nov 21, 2024
74b27cf
Tests - Fix IDE0063
Kielek Nov 21, 2024
e4022b8
tests - Fix compound assigment
Kielek Nov 21, 2024
5e3c73d
Tests - Fix IDE0045
Kielek Nov 21, 2024
007a09e
Tests - Fix IDE0051
Kielek Nov 21, 2024
690fd09
Tests - Fix IDE0052
Kielek Nov 21, 2024
fbbb6de
Tests - Fix IDE0241
Kielek Nov 21, 2024
6ed8fbd
Tests - Fix IDE0007
Kielek Nov 21, 2024
2ea6ae4
Tests - Disable IDE0230
Kielek Nov 21, 2024
e9083fa
Tests - Fix CA1515
Kielek Nov 21, 2024
bd6d33d
Fix IDE0004
Kielek Nov 21, 2024
a921fef
Merge branch 'main' into net9prep-geneva
Kielek Nov 21, 2024
69089ce
Apply suggestions from code review
Kielek Nov 22, 2024
84639c7
Merge branch 'main' into net9prep-geneva
Kielek Nov 22, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix IDE0036
Kielek committed Nov 21, 2024

Verified

This commit was signed with the committer’s verified signature.
Kielek Piotr Kiełkowicz
commit 02467e87fe4aa02c1499f59c58b5934ab2786370
Original file line number Diff line number Diff line change
@@ -51,7 +51,7 @@ public override int GetCharCount(byte[] bytes, int byteIndex, int byteCount)
return byteCount;
}

public unsafe override int GetBytes(char[] chars, int charIndex, int charCount, byte[] bytes, int byteIndex)
public override unsafe int GetBytes(char[] chars, int charIndex, int charCount, byte[] bytes, int byteIndex)
{
ValidateArgs(chars, charIndex, charCount, bytes, byteIndex, "char", "byte");
fixed (char* charPtr = chars)
@@ -63,7 +63,7 @@ public unsafe override int GetBytes(char[] chars, int charIndex, int charCount,
}
}

public unsafe override int GetChars(byte[] bytes, int byteIndex, int byteCount, char[] chars, int charIndex)
public override unsafe int GetChars(byte[] bytes, int byteIndex, int byteCount, char[] chars, int charIndex)
{
ValidateArgs(bytes, byteIndex, byteCount, chars, charIndex, "byte", "char");
fixed (byte* bytePtr = bytes)
@@ -137,7 +137,7 @@ public override unsafe int GetCharCount(byte* bytePtr, int byteCount)
return byteCount;
}

public unsafe override int GetBytes(string chars, int charIndex, int charCount, byte[] bytes, int byteIndex)
public override unsafe int GetBytes(string chars, int charIndex, int charCount, byte[] bytes, int byteIndex)
{
if (chars == null || bytes == null)
{