Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo/Geneva] Prepare to .NET9 #2342

Merged
merged 42 commits into from
Nov 22, 2024
Merged

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Nov 21, 2024

Changes

Follow up #2251

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • [ ] Unit tests added/updated
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@Kielek Kielek requested a review from a team as a code owner November 21, 2024 11:32
@github-actions github-actions bot added comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva perf Performance related labels Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 73.21429% with 45 lines in your changes missing coverage. Please review.

Project coverage is 72.16%. Comparing base (71655ce) to head (84639c7).
Report is 613 commits behind head on main.

Files with missing lines Patch % Lines
...try.Exporter.Geneva/Internal/Tld/TldLogExporter.cs 17.24% 24 Missing ⚠️
...y.Exporter.Geneva/Internal/Tld/TldTraceExporter.cs 8.33% 11 Missing ⚠️
...try.Exporter.Geneva/Internal/Tld/JsonSerializer.cs 75.00% 3 Missing ⚠️
...rter.Geneva/Internal/MsgPack/MsgPackLogExporter.cs 92.59% 2 Missing ⚠️
...r.Geneva/Internal/MsgPack/MessagePackSerializer.cs 80.00% 1 Missing ⚠️
...emetry.Exporter.Geneva/Internal/Tld/TldExporter.cs 0.00% 1 Missing ⚠️
...rter.Geneva/Internal/Tld/UncheckedASCIIEncoding.cs 50.00% 1 Missing ⚠️
...metry.Exporter.Geneva/Metrics/TlvMetricExporter.cs 83.33% 1 Missing ⚠️
...ransport/MetricWindowsEventTracingDataTransport.cs 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2342      +/-   ##
==========================================
- Coverage   73.91%   72.16%   -1.76%     
==========================================
  Files         267      369     +102     
  Lines        9615    13637    +4022     
==========================================
+ Hits         7107     9841    +2734     
- Misses       2508     3796    +1288     
Flag Coverage Δ
unittests-Contrib.Shared.Tests 84.04% <ø> (?)
unittests-Exporter.Geneva 57.24% <73.21%> (?)
unittests-Exporter.InfluxDB 95.14% <ø> (?)
unittests-Exporter.Instana 74.86% <ø> (?)
unittests-Exporter.OneCollector 94.50% <ø> (?)
unittests-Exporter.Stackdriver 79.26% <ø> (?)
unittests-Extensions 88.63% <ø> (?)
unittests-Extensions.Enrichment 100.00% <ø> (?)
unittests-Instrumentation.AWS 86.27% <ø> (?)
unittests-Instrumentation.AspNet 76.73% <ø> (?)
unittests-Instrumentation.AspNetCore 70.33% <ø> (?)
unittests-Instrumentation.ConfluentKafka 14.37% <ø> (?)
unittests-Instrumentation.ElasticsearchClient 80.12% <ø> (?)
unittests-Instrumentation.EntityFrameworkCore 57.06% <ø> (?)
unittests-Instrumentation.EventCounters 76.36% <ø> (?)
unittests-Instrumentation.GrpcCore 91.42% <ø> (?)
unittests-Instrumentation.GrpcNetClient 79.61% <ø> (?)
unittests-Instrumentation.Hangfire 93.58% <ø> (?)
unittests-Instrumentation.Http 61.68% <ø> (?)
unittests-Instrumentation.Owin 88.12% <ø> (?)
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-Instrumentation.Quartz 78.76% <ø> (?)
unittests-Instrumentation.Runtime 100.00% <ø> (?)
unittests-Instrumentation.SqlClient 91.69% <ø> (?)
unittests-Instrumentation.StackExchangeRedis 68.26% <ø> (?)
unittests-Instrumentation.Wcf 78.57% <ø> (?)
unittests-PersistentStorage 65.21% <ø> (?)
unittests-Resources.AWS 79.16% <ø> (?)
unittests-Resources.Azure 84.56% <ø> (?)
unittests-Resources.Container 67.34% <ø> (?)
unittests-Resources.Gcp 71.15% <ø> (?)
unittests-Resources.Host 73.91% <ø> (?)
unittests-Resources.OperatingSystem 76.98% <ø> (?)
unittests-Resources.Process 100.00% <ø> (?)
unittests-Resources.ProcessRuntime 78.26% <ø> (?)
unittests-Sampler.AWS 88.12% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...Telemetry.Exporter.Geneva/GenevaExporterOptions.cs 90.24% <100.00%> (+0.24%) ⬆️
...OpenTelemetry.Exporter.Geneva/GenevaLogExporter.cs 84.61% <100.00%> (+7.11%) ⬆️
...enTelemetry.Exporter.Geneva/GenevaTraceExporter.cs 82.05% <100.00%> (+7.05%) ⬆️
...xporter.Geneva/Internal/ConnectionStringBuilder.cs 95.12% <100.00%> (+2.18%) ⬆️
...xporter.Geneva/Internal/MsgPack/MsgPackExporter.cs 100.00% <100.00%> (ø)
...er.Geneva/Internal/MsgPack/MsgPackTraceExporter.cs 92.55% <100.00%> (ø)
...ry.Exporter.Geneva/Internal/TableNameSerializer.cs 98.90% <100.00%> (-0.04%) ⬇️
...ter.Geneva/Internal/Transports/EtwDataTransport.cs 85.00% <100.00%> (ø)
...eneva/Metrics/OtlpProtobuf/FieldNumberConstants.cs 80.00% <ø> (ø)
...eva/Metrics/OtlpProtobuf/OtlpProtobufSerializer.cs 90.00% <100.00%> (ø)
... and 10 more

... and 375 files with indirect coverage changes

---- 🚨 Try these New Features:

@@ -87,7 +86,6 @@ public static void JsonSerializer_Numeric()
[Trait("Platform", "Any")]
public static void JsonSerializer_String()
{
TestSerialization((string)null, "null");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this line and the two similar ones below being removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an issue reported, related to redundant casting and there is a separate tests covering such scenario: JsonSerializer_Null.

BTW most (all) cases are also covered by the generic one TestSerialization and source in Data property. Either generic test or specifc tests should be removed.

@@ -87,7 +86,6 @@ public static void JsonSerializer_Numeric()
[Trait("Platform", "Any")]
public static void JsonSerializer_String()
{
TestSerialization((string)null, "null");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an issue reported, related to redundant casting and there is a separate tests covering such scenario: JsonSerializer_Null.

BTW most (all) cases are also covered by the generic one TestSerialization and source in Data property. Either generic test or specifc tests should be removed.

@github-actions github-actions bot requested a review from CodeBlanch November 22, 2024 19:03
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kielek Kielek merged commit 7f52212 into open-telemetry:main Nov 22, 2024
208 checks passed
@Kielek Kielek deleted the net9prep-geneva branch November 22, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva perf Performance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants