Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release] core-1.10.0 release updates #2317

Merged
merged 5 commits into from
Nov 13, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/Common.props
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
<MicrosoftPublicApiAnalyzersPkgVer>[3.11.0-beta1.23525.2]</MicrosoftPublicApiAnalyzersPkgVer>
<MicrosoftSourceLinkGitHubPkgVer>[8.0.0,9.0)</MicrosoftSourceLinkGitHubPkgVer>
<OpenTelemetryCoreUnstableLatestVersion>[1.9.0-beta.2]</OpenTelemetryCoreUnstableLatestVersion>
<OpenTelemetryCoreLatestVersion>[1.9.0,2.0)</OpenTelemetryCoreLatestVersion>
<OpenTelemetryCoreLatestVersion>[1.10.0,2.0)</OpenTelemetryCoreLatestVersion>
<OpenTelemetryCoreLatestPrereleaseVersion>[1.10.0-rc.1]</OpenTelemetryCoreLatestPrereleaseVersion>
<StackExchangeRedisPkgVer>[2.6.122,3.0)</StackExchangeRedisPkgVer>
<ConfluentKafkaPkgVer>[2.4.0,3.0)</ConfluentKafkaPkgVer>
Expand Down
3 changes: 3 additions & 0 deletions src/OpenTelemetry.Exporter.InfluxDB/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
[CVE-2024-43485](https://github.com/advisories/GHSA-8g4q-xg66-9fp4).
([#2202](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2202))

* Updated OpenTelemetry core component version(s) to `1.10.0`.
([#2317](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2317))

## 1.0.0-alpha.4

Released 2024-Oct-02
Expand Down
4 changes: 2 additions & 2 deletions src/OpenTelemetry.Exporter.Instana/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
The lowest supported version is .NET Framework 4.6.2.
([#1050](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/1050))

* Updated OpenTelemetry core component version(s) to `1.9.0`.
([#1888](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/1888))
* Updated OpenTelemetry core component version(s) to `1.10.0`.
([#2317](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2317))

## 1.0.3

Expand Down
6 changes: 3 additions & 3 deletions src/OpenTelemetry.Exporter.Stackdriver/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@

## Unreleased

* Updated OpenTelemetry core component version(s) to `1.9.0`.
([#1888](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/1888))

* Drop support for .NET 6 as this target is no longer supported
and add .NET Standard 2.0 target.
([#2127](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2127))
Expand All @@ -14,6 +11,9 @@
* Google.Cloud.Trace.V2 3.3.0 -> 3.5.0
([#2127](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2127))

* Updated OpenTelemetry core component version(s) to `1.10.0`.
([#2317](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2317))

## 1.0.0-beta.6

Released 2024-Apr-22
Expand Down
3 changes: 3 additions & 0 deletions src/OpenTelemetry.Extensions.AWS/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
* Removed the unused `System.Text.Json` reference.
([#2209](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2209))

* Updated OpenTelemetry core component version(s) to `1.10.0`.
([#2317](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2317))

## 1.3.0-beta.2

Released 2024-Sep-24
Expand Down
6 changes: 3 additions & 3 deletions src/OpenTelemetry.Extensions.Enrichment/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
* Make Extensions.Enrichment AoT compatible.
([#1541](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/1541))

* Updated OpenTelemetry core component version(s) to `1.9.0`.
([#1888](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/1888))

* Drop support for .NET 6 as this target is no longer supported.
([#2126](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2126))

* Updated OpenTelemetry core component version(s) to `1.10.0`.
([#2317](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2317))
6 changes: 3 additions & 3 deletions src/OpenTelemetry.Extensions/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@
* Update BaggageActivityProcessor to require baggage key predicate.
([#1816](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/1816))

* Updated OpenTelemetry core component version(s) to `1.9.0`.
([#1888](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/1888))

* Added rate limiting sampler which limits the number of traces to the specified
rate per second. For details see
[RateLimitingSampler](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/tree/main/src/OpenTelemetry.Extensions#ratelimitingsampler).
Expand All @@ -19,6 +16,9 @@ rate per second. For details see
* Drop support for .NET 6 as this target is no longer supported and add .NET 8 target.
([#2124](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2124))

* Updated OpenTelemetry core component version(s) to `1.10.0`.
([#2317](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2317))

## 1.0.0-beta.5

Released 2024-May-08
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@
implementations](https://github.com/open-telemetry/opentelemetry-dotnet/tree/main/docs/trace/extending-the-sdk#sampler).
([#1871](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/1871))

* Updated OpenTelemetry core component version(s) to `1.10.0`.
([#2317](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2317))

## 1.9.0-beta.1

Released 2024-Jun-18
Expand Down
11 changes: 11 additions & 0 deletions src/OpenTelemetry.Instrumentation.AspNet/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
`IConfiguration`.
([#1976](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/1976))

* Updated OpenTelemetry core component version(s) to `1.10.0`.
([#2317](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2317))

## 1.9.0-beta.1

Released 2024-Jun-18
Expand Down Expand Up @@ -44,9 +47,11 @@ Released 2024-Apr-05
* **Breaking Change**: Renamed `AspNetInstrumentationOptions` to
`AspNetTraceInstrumentationOptions`.
([#1604](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/1604))

* **Breaking Change**: `server.address` and `server.port` no longer added
for `http.server.request.duration` metric.
([#1606](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1606))

* **Breaking change** Spans names and attributes
will be set as per [HTTP semantic convention v1.24.0](https://github.com/open-telemetry/semantic-conventions/blob/v1.24.0/docs/http/http-spans.md):
* span names follows: `{HTTP method} [route name if available]` pattern
Expand All @@ -62,6 +67,7 @@ Released 2024-Apr-05
* `url.scheme` added with `http` or `https` value,
* `user_agent.original` replaces `http.user_agent`.
([#1607](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/1607))

* `ActivitySource.Version` is set to NuGet package version.
([#1624](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/1624))

Expand Down Expand Up @@ -252,6 +258,7 @@ Released 2021-Mar-19
and ActivityProcessors. Samplers, ActivityProcessor.OnStart will now get the
Activity before any enrichment done by the instrumentation.
([#1836](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1836))

* Performance optimization by leveraging sampling decision and short circuiting
activity enrichment.
([#1903](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1903))
Expand All @@ -276,8 +283,10 @@ Released 2020-Nov-5
CompositeTextMapPropagator. IPropagator is renamed to TextMapPropagator and
changed from interface to abstract class.
([#1427](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1427))

* Propagators.DefaultTextMapPropagator will be used as the default Propagator.
([#1427](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1428))

* Removed Propagator from Instrumentation Options. Instrumentation now always
respect the Propagator.DefaultTextMapPropagator.
([#1448](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1448))
Expand All @@ -290,6 +299,7 @@ Released 2020-Oct-16
Activity.CustomProperty. To enrich activity, use the Enrich action on the
instrumentation.
([#1261](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1261))

* Span Status is populated as per new spec
([#1313](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1313))

Expand All @@ -313,6 +323,7 @@ Released 2020-08-28
BaggageFormat)`. Baggage sent via the [W3C
Baggage](https://github.com/w3c/baggage/blob/master/baggage/HTTP_HEADER_FORMAT.md)
header will now be parsed and set on incoming Http spans.

* Renamed `ITextPropagator` to `IPropagator`
([#1190](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1190))

Expand Down
3 changes: 3 additions & 0 deletions src/OpenTelemetry.Instrumentation.AspNetCore/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
* Drop support for .NET 6 as this target is no longer supported.
([#2138](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2138))

* Updated OpenTelemetry core component version(s) to `1.10.0`.
([#2317](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2317))

## 1.9.0

Released 2024-Jun-17
Expand Down
3 changes: 3 additions & 0 deletions src/OpenTelemetry.Instrumentation.Cassandra/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## Unreleased

* Updated OpenTelemetry core component version(s) to `1.10.0`.
([#2317](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2317))

## 1.0.0-beta.2

Released 2024-Oct-02
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
and add .NET Standard 2.0 target.
([#2142](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2142))

* Updated OpenTelemetry core component version(s) to `1.10.0`.
([#2317](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2317))

## 0.1.0-alpha.2

Released 2024-Sep-18
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,14 @@
Redact `username` and `password` part of the `url.full`.
([#1684](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/1684))

* Updated OpenTelemetry core component version(s) to `1.9.0`.
([#1888](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/1888))

* Lowered the `System.Text.Json` reference to `4.7.2` for `net462` and
`netstandard2.0` targets in response to
[CVE-2024-43485](https://msrc.microsoft.com/update-guide/vulnerability/CVE-2024-43485).
([#2198](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2198))

* Updated OpenTelemetry core component version(s) to `1.10.0`.
([#2317](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2317))

## 1.0.0-beta.5

Released 2023-Oct-24
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@
[spans](https://github.com/open-telemetry/semantic-conventions/blob/v1.28.0/docs/database/database-spans.md).
([#2130](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2130))

* Updated OpenTelemetry core component version(s) to `1.10.0`.
([#2317](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2317))

## 1.0.0-beta.12

Released 2024-Jun-18
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
* `Meter.Version` is set to NuGet package version.
([#1624](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/1624))

* Updated OpenTelemetry core component version(s) to `1.9.0`.
([#1888](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/1888))
* Updated OpenTelemetry core component version(s) to `1.10.0`.
([#2317](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2317))

## 1.5.1-alpha.1

Expand Down
5 changes: 3 additions & 2 deletions src/OpenTelemetry.Instrumentation.GrpcCore/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,13 @@

## Unreleased

* Updated OpenTelemetry core component version(s) to `1.9.0`.
([#1888](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/1888))
* Updated minimal supported version of `Grpc.Core.Api` to `2.46.6`.
([#1936](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/1936),
[#1940](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/1940))

* Updated OpenTelemetry core component version(s) to `1.10.0`.
([#2317](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2317))

## 1.0.0-beta.6

Released 2024-May-21
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
* Drop support for .NET 6 as this target is no longer supported.
([#2150](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2150))

* Updated OpenTelemetry core component version(s) to `1.10.0`.
([#2317](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2317))

## 1.9.0-beta.1

Released 2024-Jun-17
Expand Down
3 changes: 3 additions & 0 deletions src/OpenTelemetry.Instrumentation.Hangfire/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## Unreleased

* Updated OpenTelemetry core component version(s) to `1.10.0`.
([#2317](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2317))

## 1.9.0-beta.1

Released 2024-Oct-02
Expand Down
3 changes: 3 additions & 0 deletions src/OpenTelemetry.Instrumentation.Http/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
* Drop support for .NET 6 as this target is no longer supported.
([#2152](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2152))

* Updated OpenTelemetry core component version(s) to `1.10.0`.
([#2317](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2317))

## 1.9.0

Released 2024-Jun-17
Expand Down
6 changes: 3 additions & 3 deletions src/OpenTelemetry.Instrumentation.Owin/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@
attribute schema.
([#2028](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2028))

* Updated OpenTelemetry core component version(s) to `1.9.0`.
([#1888](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/1888))

* Updated registration extension code to retrieve environment variables through
`IConfiguration`.
([#1973](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/1973))
Expand All @@ -19,6 +16,9 @@
`OpenTelemetry` (SDK) package.
([#1977](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/1977))

* Updated OpenTelemetry core component version(s) to `1.10.0`.
([#2317](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2317))

## 1.0.0-rc.6

Released 2024-Apr-19
Expand Down
3 changes: 3 additions & 0 deletions src/OpenTelemetry.Instrumentation.Process/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## Unreleased

* Updated OpenTelemetry core component version(s) to `1.10.0`.
([#2317](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2317))

## 0.5.0-beta.7

Released 2024-Sep-25
Expand Down
3 changes: 3 additions & 0 deletions src/OpenTelemetry.Instrumentation.Quartz/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## Unreleased

* Updated OpenTelemetry core component version(s) to `1.10.0`.
([#2317](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2317))

## 1.0.0-beta.3

Released 2024-Jun-18
Expand Down
3 changes: 3 additions & 0 deletions src/OpenTelemetry.Instrumentation.Runtime/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
* Drop support for .NET 6 as this target is no longer supported and add .NET 8 target.
([#2155](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2155))

* Updated OpenTelemetry core component version(s) to `1.10.0`.
([#2317](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2317))

## 1.9.0

Released 2024-Jun-18
Expand Down
9 changes: 9 additions & 0 deletions src/OpenTelemetry.Instrumentation.SqlClient/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

* Drop support for .NET 6 as this target is no longer supported.
([#2159](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2159))

* The new database semantic conventions can be opted in to by setting
the `OTEL_SEMCONV_STABILITY_OPT_IN` environment variable. This allows for a
transition period for users to experiment with the new semantic conventions
Expand All @@ -28,26 +29,34 @@
[#2277](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2277),
[#2262](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2262),
[#2279](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2279))

* **Breaking change**: The `peer.service` and `server.socket.address` attributes
are no longer emitted. Users should rely on the `server.address` attribute
for the same information. Note that `server.address` is only included when
the `EnableConnectionLevelAttributes` option is enabled.
([#2229](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2229))

* **Breaking change**: When `EnableConnectionLevelAttributes` is enabled, the
`server.port` attribute will now be written as an integer to be compliant with
the [semantic conventions](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/attributes-registry/server.md).
Previously, it was written as a string.
([#2233](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2233))

* The `EnableConnectionLevelAttributes` option is now enabled by default.
([#2249](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2249))

* The following attributes are now provided when starting an activity for a database
call: `db.system`, `db.name` (old conventions), `db.namespace` (new conventions),
`server.address`, and `server.port`. These attributes are now available for sampling
decisions.
([#2277](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2277))

* **Breaking change**: The `SetDbStatementForStoredProcedure` option has been removed.
([#TBD](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/TBD))

* Updated OpenTelemetry core component version(s) to `1.10.0`.
([#2317](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2317))

## 1.9.0-beta.1

Released 2024-Jun-17
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,17 @@
* Drop support for .NET 6 as this target is no longer supported and add .NET 8 target.
([#2160](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2160))

* Updated OpenTelemetry core component version(s) to `1.10.0`.
([#2317](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/2317))

## 1.9.0-beta.1

Released 2024-Jul-23

* Add support for instrumenting `IConnectionMultiplexer`
which is added with service key.
([#1885](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/1885))

* Update `StackExchange.Redis` version to `2.6.122`, resolving warnings about
[CVE-2021-24112](https://github.com/advisories/GHSA-rxg9-xrhp-64gj).
([#1961](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/1961))
Expand Down
Loading
Loading