[release] core-1.10.0 release updates #2317
Conversation
opentelemetrybot
temporarily deployed
to
internal
GitHub Actions
Inactive
github-actions
bot
assigned CodeBlanch, ejsmith, fred2u, g7ed6e, hananiel, Havret, IliaBrahinets, iskiselev, Kielek and lachmatt
github-actions
bot
added
infra
github-actions
bot
requested review from
CodeBlanch,
ejsmith,
fred2u,
g7ed6e,
hananiel,
Havret,
IliaBrahinets,
iskiselev,
Kielek,
lachmatt,
maldago,
matt-hensley and
mic-max
github-actions
bot
added
comp:resources.gcp
github-actions
bot
requested review from
cijothomas,
muhammad-othman,
Oberon00,
rypdal and
utpilla
github-actions
bot
added
documentation
| @@ -88,7 +87,7 @@ public override void OnEnd(LogRecord data) | |||
|
|
|||
| if (data.Exception != null) | |||
| { | |||
| activity.RecordException(data.Exception); | |||
| activity.AddException(data.Exception); | |||
There was a problem hiding this comment.
Where something was calling ActivityExtensions.RecordException I switched it to call Activity.AddException because Activity.AddException does the same job (add event matching exception semantic conventions), no migration necessary.
| @@ -59,8 +59,10 @@ public override void RecordException(Exception exception, Attributes? attributes | |||
|
|
|||
| var tags = attributes != null ? new TagList(attributes.AllAttributes.ToArray()) : default; | |||
|
|
|||
| this.activity.RecordException(exception, tags); | |||
| this.activity.AddException(exception, tags); | |||
| #pragma warning disable CS0618 // Type or member is obsolete | |||
There was a problem hiding this comment.
Where something was calling ActivityExtensions.SetStatus I suppressed warning instead of updating to use Activity.Status \ Activity.StatusDescription. The reason for that is they don't do the same things. In order for Activity.Status \ Activity.StatusDescription to work, users need to also upgrade to a compatible exporter which understands the status fields on Activity. I decided calling the old extension for now was the safer bet.
There was a problem hiding this comment.
Exception made in ElasticsearchRequestPipelineDiagnosticListener which was calling the newer Activity APIs to translate http status code but calling the obsolete extensions when there was an exception. Updated to use the newer Activity APIs there so it is consistent.
| @@ -59,8 +59,10 @@ public override void RecordException(Exception exception, Attributes? attributes | |||
|
|
|||
| var tags = attributes != null ? new TagList(attributes.AllAttributes.ToArray()) : default; | |||
|
|
|||
| this.activity.RecordException(exception, tags); | |||
| this.activity.AddException(exception, tags); | |||
| #pragma warning disable CS0618 // Type or member is obsolete | |||
Note: This PR was opened automatically by the core version update workflow.
Merge once packages are available on NuGet and the build passes.
Changes
OpenTelemetryCoreLatestVersioninCommon.propsto1.10.0.