Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Exporter.Geneva] Replace hardcoded TFM in test projects #2128

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

joegoldman2
Copy link
Contributor

Changes

#2123 introduced a new MSBuild prop SupportedNetTargetsWithoutNet6 used in test projects. This PR uses it in Geneva test projects.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@joegoldman2 joegoldman2 requested a review from a team as a code owner October 2, 2024 10:06
@github-actions github-actions bot added perf Performance related comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva labels Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.94%. Comparing base (71655ce) to head (1d57555).
Report is 467 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2128       +/-   ##
===========================================
- Coverage   73.91%   58.94%   -14.98%     
===========================================
  Files         267       44      -223     
  Lines        9615     3924     -5691     
===========================================
- Hits         7107     2313     -4794     
+ Misses       2508     1611      -897     
Flag Coverage Δ
unittests-Exporter.Geneva 58.94% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 249 files with indirect coverage changes

@joegoldman2 joegoldman2 changed the title [Exporter.Geneva] Replace hardcoded TFM for test projects [Exporter.Geneva] Replace hardcoded TFM in test projects Oct 2, 2024
@CodeBlanch CodeBlanch merged commit 3ba134e into open-telemetry:main Oct 2, 2024
59 checks passed
@joegoldman2 joegoldman2 deleted the geneva-tests-tfm branch October 2, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva perf Performance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants