Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Exporter.OneCollector] Remove .NET 6 target #2123

Merged
merged 7 commits into from
Oct 1, 2024

Conversation

joegoldman2
Copy link
Contributor

Changes

Remove .NET 6 target which will be very soon out of support.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@joegoldman2 joegoldman2 requested a review from a team as a code owner October 1, 2024 05:46
@github-actions github-actions bot requested review from CodeBlanch and reyang October 1, 2024 05:47
@github-actions github-actions bot added comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector perf Performance related labels Oct 1, 2024
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.74%. Comparing base (71655ce) to head (51283ee).
Report is 464 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2123      +/-   ##
==========================================
- Coverage   73.91%   67.74%   -6.18%     
==========================================
  Files         267      339      +72     
  Lines        9615    12736    +3121     
==========================================
+ Hits         7107     8628    +1521     
- Misses       2508     4108    +1600     
Flag Coverage Δ
unittests-Exporter.Geneva 48.40% <ø> (?)
unittests-Exporter.InfluxDB 95.88% <ø> (?)
unittests-Exporter.Instana 71.24% <ø> (?)
unittests-Exporter.OneCollector 94.32% <ø> (?)
unittests-Exporter.Stackdriver 75.73% <ø> (?)
unittests-Extensions 88.57% <ø> (?)
unittests-Extensions.AWS 72.39% <ø> (?)
unittests-Extensions.Enrichment 100.00% <ø> (?)
unittests-Instrumentation.AWS 84.78% <ø> (?)
unittests-Instrumentation.AWSLambda 88.92% <ø> (?)
unittests-Instrumentation.AspNet 76.73% <ø> (?)
unittests-Instrumentation.AspNetCore 85.27% <ø> (?)
unittests-Instrumentation.ConfluentKafka 14.12% <ø> (?)
unittests-Instrumentation.ElasticsearchClient 79.87% <ø> (?)
unittests-Instrumentation.EntityFrameworkCore 55.49% <ø> (?)
unittests-Instrumentation.EventCounters 76.36% <ø> (?)
unittests-Instrumentation.GrpcNetClient 79.61% <ø> (?)
unittests-Instrumentation.Hangfire 93.58% <ø> (?)
unittests-Instrumentation.Http 82.05% <ø> (?)
unittests-Instrumentation.Owin 85.97% <ø> (?)
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-Instrumentation.Quartz 78.94% <ø> (?)
unittests-Instrumentation.Runtime 100.00% <ø> (?)
unittests-Instrumentation.SqlClient 90.90% <ø> (?)
unittests-Instrumentation.StackExchangeRedis 67.02% <ø> (?)
unittests-Instrumentation.Wcf 48.91% <ø> (?)
unittests-PersistentStorage 65.78% <ø> (?)
unittests-Resources.AWS 77.93% <ø> (?)
unittests-Resources.Azure 83.89% <ø> (?)
unittests-Resources.Container 72.41% <ø> (?)
unittests-Resources.Gcp 72.54% <ø> (?)
unittests-Resources.Host 70.08% <ø> (?)
unittests-Resources.OperatingSystem 77.20% <ø> (?)
unittests-Resources.Process 100.00% <ø> (?)
unittests-Resources.ProcessRuntime 77.08% <ø> (?)
unittests-Sampler.AWS 87.61% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
....Exporter.OneCollector/Internal/CallbackManager.cs 96.00% <ø> (+0.16%) ⬆️
...Internal/Serialization/BatchSerializationResult.cs 100.00% <ø> (ø)
...rialization/CommonSchemaJsonSerializationHelper.cs 100.00% <ø> (ø)
...lector/Internal/Transports/TransportSendRequest.cs 100.00% <ø> (ø)

... and 371 files with indirect coverage changes

@github-actions github-actions bot added the infra Infra work - CI/CD, code coverage, linters label Oct 1, 2024
@CodeBlanch CodeBlanch merged commit d700e8e into open-telemetry:main Oct 1, 2024
218 checks passed
@joegoldman2 joegoldman2 deleted the feat/one-collector-tfm branch October 2, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector infra Infra work - CI/CD, code coverage, linters perf Performance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants