Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Exporter.Geneva] Remove .NET 6 target #2117

Merged
merged 7 commits into from
Sep 30, 2024

Conversation

joegoldman2
Copy link
Contributor

Changes

Remove .NET 6 target which will be very soon out of support.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@joegoldman2 joegoldman2 requested a review from a team as a code owner September 28, 2024 14:29
@github-actions github-actions bot added comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva perf Performance related labels Sep 28, 2024
Copy link

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.12%. Comparing base (71655ce) to head (96d88eb).
Report is 457 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2117       +/-   ##
===========================================
- Coverage   73.91%   59.12%   -14.80%     
===========================================
  Files         267       44      -223     
  Lines        9615     3924     -5691     
===========================================
- Hits         7107     2320     -4787     
+ Misses       2508     1604      -904     
Flag Coverage Δ
unittests-Exporter.Geneva 59.12% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...xporter.Geneva/Internal/MsgPack/MsgPackExporter.cs 93.93% <ø> (ø)
...rter.Geneva/Internal/MsgPack/MsgPackLogExporter.cs 94.44% <ø> (ø)
...er.Geneva/Internal/MsgPack/MsgPackTraceExporter.cs 94.95% <ø> (ø)
...rter.Geneva/Internal/Tld/UncheckedASCIIEncoding.cs 17.30% <ø> (ø)
...ry.Exporter.Geneva/Metrics/GenevaMetricExporter.cs 96.96% <ø> (+30.30%) ⬆️

... and 247 files with indirect coverage changes

@joegoldman2 joegoldman2 marked this pull request as draft September 28, 2024 14:52
@joegoldman2 joegoldman2 marked this pull request as ready for review September 28, 2024 16:08
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch merged commit 794eb48 into open-telemetry:main Sep 30, 2024
59 checks passed
@joegoldman2 joegoldman2 deleted the geneva-tfm branch September 30, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva perf Performance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants