-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[geneva] Vendor code for writing tracepoints on Linux #2114
[geneva] Vendor code for writing tracepoints on Linux #2114
Conversation
…Geneval external folder.
Could you please update the PR summary to show how you decided to select only part of these files from the other repo. Later if we need to copy an update it will be useful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, consider adding information on why #nullable enable
is added on every file.
@rajkumar-rangaraj @TimothyMothra I pushed some changes geared towards reducing the amount of changes to the files which are being vendored. Goal being to make it easier to update them in the future if needed. |
[Split off from #2113]
Changes
Adds code from https://github.com/microsoft/LinuxTracepoints-Net/ into the "External" folder in the GenevaExporter project. Decided to vendor this code because a) that package doesn't have a strong name which breaks the build and b) we're hoping dotnet/runtime will add support for user_events in the future and we won't need a dependency.
Geneva will only be using the
PerfTracepoint
class. The files being included here are the subset from the repo required to get /Provider/PerfTracepoint.cs building.Merge requirement checklist