-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Extensions.AWS] Remove NuGet reference to System.Net.Http #1713
[Extensions.AWS] Remove NuGet reference to System.Net.Http #1713
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1713 +/- ##
==========================================
+ Coverage 73.91% 80.17% +6.25%
==========================================
Files 267 116 -151
Lines 9615 3077 -6538
==========================================
- Hits 7107 2467 -4640
+ Misses 2508 610 -1898
Flags with carried forward coverage won't be shown. Click here to find out more. |
https://github.com/open-telemetry/opentelemetry-dotnet-contrib/actions/runs/9021608738/job/24789303314?pr=1713#step:2:10 The workflow is broken it seems. |
I think the problem is with definition of who is the "collaborator" by the GitHub. I didn't find a way to mark all codeowners as collaborators. I suppose we could change the assign job, to call all code-owners in the comments. It should be always working. |
Changes
Remove the reference to System.Net.Http to reduce noise in the NuGet dependency graph.
Including this reference requires restoring all these packages during builds. Most of them are stubs that don't contain binaries. They are not required on any of the supported .NET runtimes. (In fact, this project doesn't reference anything from the System.Net.Http namespace.)