Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component owners- mention component owners in PRs #1715

Closed
Kielek opened this issue May 10, 2024 · 11 comments · Fixed by #1822
Closed

Component owners- mention component owners in PRs #1715

Kielek opened this issue May 10, 2024 · 11 comments · Fixed by #1822
Labels
infra Infra work - CI/CD, code coverage, linters

Comments

@Kielek
Copy link
Contributor

Kielek commented May 10, 2024

https://github.com/open-telemetry/opentelemetry-dotnet-contrib/actions/runs/9021608738/job/24789303314?pr=1713#step:2:10 The workflow is broken it seems.

I think the problem is with definition of who is the "collaborator" by the GitHub. I didn't find a way to mark all codeowners as collaborators. I suppose we could change the assign job, to call all code-owners in the comments. It should be always working.

Originally posted by @Kielek in #1713 (comment)

@Kielek Kielek added the infra Infra work - CI/CD, code coverage, linters label May 10, 2024
@reyang
Copy link
Member

reyang commented May 10, 2024

I think the gap here is that folks should first become OpenTelemetry Member? Probably good to enforce it.

@Kielek
Copy link
Contributor Author

Kielek commented May 13, 2024

I am not sure if it sufficient, last status only @atshaw43 and @zivaninstana are not part of this group. Ref: #1201

@Kielek Kielek changed the title Codeowners - mention codeowners in PRs Component owners- mention component owners in PRs May 13, 2024
@reyang
Copy link
Member

reyang commented May 13, 2024

I am not sure if it sufficient, last status only @atshaw43 and @zivaninstana are not part of this group. Ref: #1201

@Kielek do you have a concrete example that folks are already OpenTelemetry Members but the issue cannot be assigned to them? I might be able to help if you can provide a repro.

@Kielek
Copy link
Contributor Author

Kielek commented May 14, 2024

@reyang, I am pretty sure that I saw such PRs, but I cannot find anything like this, probably one of these accounts were involved in the requests.
For now, we have two problematic accounts.

@atshaw - received invitation (twice) open-telemetry/community#1629
@zivaninstana - also received invitation open-telemetry/community#1589

Both never accepted.

@zivaninstana
Copy link
Contributor

I will accept, I just need to see where the request is sent

@zivaninstana
Copy link
Contributor

Sorry, no request, invitation

@zivaninstana
Copy link
Contributor

Please send it again, I will accept. I am really keen on continuing to contribute.

@reyang
Copy link
Member

reyang commented May 17, 2024

Please send it again, I will accept. I am really keen on continuing to contribute.

I've resent the invite, sorry for the delay (I don't actively monitor the conversations in this repo unless folks explicitly tag me):

image

@Kielek
Copy link
Contributor Author

Kielek commented May 17, 2024

@zivaninstana, please check all you email account associated with GitHub account. Invitation will be expired after some time, so please do not postpone this activity.

@zivaninstana
Copy link
Contributor

Thank you folks. I just accepted an invitation. I really look forward to working with you.

@ppittle
Copy link
Member

ppittle commented May 20, 2024

Created #1822 to (temporarily) remove @atshaw from component owners until he can fully on-board with Open Telemetry Community

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Infra work - CI/CD, code coverage, linters
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants