Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump OTel to 1.7.0 for ResourceDetectors Host and Process #1518

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Dec 21, 2023

Fixes #1507 (comment) and #1506 (comment)

Changes

Bump OTel to 1.7.0 for ResourceDetectors Host and Process

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • [ ] Design discussion issue #
  • [ ] Changes in public API reviewed

@Kielek Kielek requested a review from a team December 21, 2023 06:56
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (71655ce) 73.91% compared to head (cc5df2b) 95.77%.
Report is 109 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1518       +/-   ##
===========================================
+ Coverage   73.91%   95.77%   +21.85%     
===========================================
  Files         267        4      -263     
  Lines        9615       71     -9544     
===========================================
- Hits         7107       68     -7039     
+ Misses       2508        3     -2505     
Flag Coverage Δ
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-ResourceDetectors.Host 62.50% <ø> (?)
unittests-ResourceDetectors.Process 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 264 files with indirect coverage changes

@Kielek
Copy link
Contributor Author

Kielek commented Dec 21, 2023

@cijothomas, FYI

@Kielek Kielek added comp:resources.process Things related to OpenTelemetry.Resources.Process comp:resources.host Things related to OpenTelemetry.Resources.Host labels Dec 21, 2023
@cijothomas cijothomas merged commit 6bb57e2 into open-telemetry:main Dec 21, 2023
44 checks passed
@Kielek Kielek deleted the resource-detectors-process-and-host-otel-update branch December 21, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:resources.host Things related to OpenTelemetry.Resources.Host comp:resources.process Things related to OpenTelemetry.Resources.Process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants