Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResourceDetectors - Process #1506

Merged
merged 5 commits into from
Dec 21, 2023

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Dec 20, 2023

Fixes N/A.

Changes

Initial implementation for process.pid detector from https://github.com/open-telemetry/semantic-conventions/blob/main/docs/resource/process.md#process (this attribute is what I need for now).

The plan is to release shortly as alpha with reference to OTel 1.6.0.
Then create follow up help-wanted issue to extend it for another attributes and update OTel to 1.7.0.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • [ ] Design discussion issue #
  • Changes in public API reviewed

Notes

Previous initial implementation of resource detector: #1449
You can expect one more similar, for https://github.com/open-telemetry/semantic-conventions/blob/main/docs/resource/host.md, espiecially host.name.

@Kielek Kielek added the comp:resources.process Things related to OpenTelemetry.Resources.Process label Dec 20, 2023
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 50 lines in your changes are missing coverage. Please review.

Comparison is base (71655ce) 73.91% compared to head (76eb0a7) 73.36%.
Report is 106 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1506      +/-   ##
==========================================
- Coverage   73.91%   73.36%   -0.55%     
==========================================
  Files         267      254      -13     
  Lines        9615     9414     -201     
==========================================
- Hits         7107     6907     -200     
+ Misses       2508     2507       -1     
Flag Coverage Δ
unittests-Exporter.Geneva 58.03% <49.46%> (?)
unittests-Exporter.OneCollector 89.72% <100.00%> (?)
unittests-Extensions 82.75% <100.00%> (?)
unittests-Instrumentation.AspNet 75.66% <ø> (?)
unittests-Instrumentation.EventCounters 75.92% <ø> (?)
unittests-Instrumentation.Owin 85.71% <ø> (?)
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-Instrumentation.Runtime 100.00% <ø> (?)
unittests-Instrumentation.StackExchangeRedis 71.00% <ø> (?)
unittests-Instrumentation.Wcf 78.47% <ø> (?)
unittests-PersistentStorage 58.80% <ø> (?)
unittests-ResourceDetectors.Azure 80.90% <ø> (?)
unittests-ResourceDetectors.Process 100.00% <ø> (?)
unittests-ResourceDetectors.ProcessRuntime 76.08% <ø> (?)
unittests-Solution 80.55% <90.62%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
....Exporter.Geneva/GenevaExporterHelperExtensions.cs 100.00% <ø> (+31.81%) ⬆️
...Telemetry.Exporter.Geneva/GenevaExporterOptions.cs 90.00% <ø> (ø)
...OpenTelemetry.Exporter.Geneva/GenevaLogExporter.cs 85.00% <ø> (+7.50%) ⬆️
...lemetry.Exporter.Geneva/GenevaLoggingExtensions.cs 100.00% <ø> (+14.28%) ⬆️
...enTelemetry.Exporter.Geneva/GenevaTraceExporter.cs 82.50% <ø> (+7.50%) ⬆️
...xporter.Geneva/Internal/ConnectionStringBuilder.cs 92.94% <100.00%> (ø)
...ry.Exporter.Geneva/Internal/ExporterEventSource.cs 14.28% <ø> (+9.52%) ⬆️
...eneva/Internal/ReentrantActivityExportProcessor.cs 100.00% <ø> (ø)
...porter.Geneva/Internal/ReentrantExportProcessor.cs 100.00% <ø> (ø)
...ry.Exporter.Geneva/Internal/TableNameSerializer.cs 98.93% <ø> (ø)
... and 100 more

... and 170 files with indirect coverage changes

@Kielek Kielek marked this pull request as ready for review December 20, 2023 06:21
@Kielek Kielek requested a review from a team December 20, 2023 06:21
@Kielek Kielek mentioned this pull request Dec 20, 2023
2 tasks
<MinVerTagPrefix>ResourceDetectors.Process-</MinVerTagPrefix>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="OpenTelemetry" Version="1.6.0" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OTelSdkVersion can be used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From PR description:

The plan is to release shortly as alpha with reference to OTel 1.6.0.
Then create follow up help-wanted issue to extend it for another attributes and update OTel to 1.7.0.

Will do, just after initial release.

@Kielek Kielek merged commit d971004 into open-telemetry:main Dec 21, 2023
104 of 105 checks passed
@Kielek Kielek deleted the resource-detector-process branch December 21, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:resources.process Things related to OpenTelemetry.Resources.Process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants