Instrumentation.AWSLambda: Upgrade & explicitly depend on Newtonsoft.Json #1273
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1270 (alternative to that PR).
Related to a similar change in the XRay dependency: #1092
Changes
Quoting the CHANGELOG:
Add explicit dependency on Newtonsoft.Json, upgrading the mimimum version.
This resolves a warning that some dependency analyzers may produce where this
package would transitively depend on a vulnerable version of Newtonsoft.Json
through Amazon.Lambda.APIGatewayEvents.
This also avoids a potential issue where the instrumentation would try to call
a Newtonsoft.Json function when no other package nor the app itself depends on
Newtonsoft.Json, since the transitive dependency would be ignored unless using
application were compiled against a TargetFramework older than Core 3.1.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes[ ] Design discussion issue #N/A[ ] Changes in public API reviewedN/A