Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrumentation.AWSLambda: Upgrade & explicitly depend on Newtonsoft.Json #1273

Merged

Conversation

Oberon00
Copy link
Member

@Oberon00 Oberon00 commented Jul 20, 2023

Closes #1270 (alternative to that PR).

Related to a similar change in the XRay dependency: #1092

Changes

Quoting the CHANGELOG:

  • Add explicit dependency on Newtonsoft.Json, upgrading the mimimum version.

    This resolves a warning that some dependency analyzers may produce where this
    package would transitively depend on a vulnerable version of Newtonsoft.Json
    through Amazon.Lambda.APIGatewayEvents.

    This also avoids a potential issue where the instrumentation would try to call
    a Newtonsoft.Json function when no other package nor the app itself depends on
    Newtonsoft.Json, since the transitive dependency would be ignored unless using
    application were compiled against a TargetFramework older than Core 3.1.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • [ ] Design discussion issue # N/A
  • [ ] Changes in public API reviewed N/A

@Oberon00 Oberon00 force-pushed the lambda-updgrade-newtonsoft branch from c730a6d to fa8ab01 Compare July 20, 2023 07:53
@Oberon00 Oberon00 changed the title Instrumenation.AWSLambda: Upgrade & explicitly depend on Newtonsoft.Json Instrumentation.AWSLambda: Upgrade & explicitly depend on Newtonsoft.Json Jul 20, 2023
@Oberon00 Oberon00 marked this pull request as ready for review July 20, 2023 08:56
@Oberon00 Oberon00 requested a review from a team July 20, 2023 08:56
@utpilla
Copy link
Contributor

utpilla commented Jul 21, 2023

Could you update the branch with the latest changes? It looks like maintainers wouldn't have access to do that for this branch.

@utpilla utpilla added the comp:instrumentation.awslambda Things related to OpenTelemetry.Instrumentation.AWSLambda label Jul 21, 2023
@Oberon00
Copy link
Member Author

I updated the branch and also changed permissions so that repository maintainers should now be able to push/update here.

@Kielek Kielek merged commit b0079f7 into open-telemetry:main Jul 24, 2023
@Oberon00 Oberon00 deleted the lambda-updgrade-newtonsoft branch July 24, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.awslambda Things related to OpenTelemetry.Instrumentation.AWSLambda
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants