-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Extensions.AWSXray] Replace Newtonsoft.Json with System.Text.Json #1092
Merged
Kielek
merged 3 commits into
open-telemetry:main
from
wjrogers:extensions-awsxray-remove-newtonsoft
Mar 24, 2023
Merged
[Extensions.AWSXray] Replace Newtonsoft.Json with System.Text.Json #1092
Kielek
merged 3 commits into
open-telemetry:main
from
wjrogers:extensions-awsxray-remove-newtonsoft
Mar 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kielek
reviewed
Mar 20, 2023
src/OpenTelemetry.Contrib.Extensions.AWSXRay/OpenTelemetry.Contrib.Extensions.AWSXRay.csproj
Show resolved
Hide resolved
Kielek
added
the
comp:extensions.aws
Things related to OpenTelemetry.Extensions.AWS
label
Mar 20, 2023
srprash
approved these changes
Mar 24, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1092 +/- ##
==========================================
- Coverage 71.33% 69.30% -2.03%
==========================================
Files 222 214 -8
Lines 8396 8359 -37
==========================================
- Hits 5989 5793 -196
- Misses 2407 2566 +159
|
Kielek
approved these changes
Mar 24, 2023
This was referenced Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Replace OpenTelemetry.Contrib.Extensions.AWSXRay's Newtonsoft.Json dependency with System.Text.Json. When targeting newer runtimes, this effectively removes the dependency because System.Text.Json is part of the base class library.
There are no changes to the public API, and test coverage of the affected code looks good.