Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Extensions.AWSXray] Replace Newtonsoft.Json with System.Text.Json #1092

Merged

Conversation

wjrogers
Copy link
Contributor

Changes

Replace OpenTelemetry.Contrib.Extensions.AWSXRay's Newtonsoft.Json dependency with System.Text.Json. When targeting newer runtimes, this effectively removes the dependency because System.Text.Json is part of the base class library.

There are no changes to the public API, and test coverage of the affected code looks good.

@wjrogers wjrogers requested a review from a team March 18, 2023 22:34
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 18, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: wjrogers / name: Will Rogers (f0bd7ef)

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #1092 (16f56b8) into main (365e131) will decrease coverage by 2.03%.
The diff coverage is 93.75%.

❗ Current head 16f56b8 differs from pull request most recent head 4ec8bcc. Consider uploading reports for the commit 4ec8bcc to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1092      +/-   ##
==========================================
- Coverage   71.33%   69.30%   -2.03%     
==========================================
  Files         222      214       -8     
  Lines        8396     8359      -37     
==========================================
- Hits         5989     5793     -196     
- Misses       2407     2566     +159     
Impacted Files Coverage Δ
...ns.AWSXRay/Resources/Models/AWSEBSMetadataModel.cs 100.00% <ø> (ø)
...AWSXRay/Resources/Models/AWSEKSClusterDataModel.cs 100.00% <ø> (ø)
...nsions.AWSXRay/Resources/AWSECSResourceDetector.cs 83.69% <92.30%> (-1.09%) ⬇️
...ensions.AWSXRay/Resources/ResourceDetectorUtils.cs 100.00% <100.00%> (ø)

... and 11 files with indirect coverage changes

@Kielek Kielek merged commit 1e47f1c into open-telemetry:main Mar 24, 2023
@wjrogers wjrogers deleted the extensions-awsxray-remove-newtonsoft branch March 24, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:extensions.aws Things related to OpenTelemetry.Extensions.AWS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants